From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753929AbbIPNzp (ORCPT ); Wed, 16 Sep 2015 09:55:45 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:55214 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbbIPNzn (ORCPT ); Wed, 16 Sep 2015 09:55:43 -0400 From: Arnd Bergmann To: y2038@lists.linaro.org Cc: WEN Pingbo , linux-input@vger.kernel.org, Dmitry Torokhov , linux-kernel@vger.kernel.org Subject: Re: [Y2038] [PATCH V2] hp_sdc_rtc: fixed y2038 problem in proc_show Date: Wed, 16 Sep 2015 15:55:37 +0200 Message-ID: <2616886.83FcmajDm5@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1442411138-773-1-git-send-email-pingbo.wen@linaro.org> References: <3021182.6jgkaVHA9u@wuerfel> <1442411138-773-1-git-send-email-pingbo.wen@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:BWxKzT2zkB/QwzrBuk6BKVIAQLlw3xbwJc+Fbf8vpViJRRGo++k a3UGRv3YAadtzjWfetjZkwKjG3oZ5xEFWb23y14JMWJaR4G6y6eGk1XOuA3QloZ9GunRNbe mx/q/q6Ok7TUAlQJ/WFs1ncgPIxA5VCR0YHtMvlTZck6YA+CTnzXbp1pILMkLNoHQGkqDWa xacbo2Ti/rhZ3IAnrKixw== X-UI-Out-Filterresults: notjunk:1;V01:K0:d20PvJ4afoE=:AbB7PUu7Gf88lez5Xo0m7I k1EiUK24+/raYgJAU46Nyudrkr3h/W2jtCqJCheBnBONpK2ZddtAcA562IAMV9WzkaGQYI1mG 9wXxZ/TptNOwJOPv6Fe9OVY1/BK85DHAzWSiZAVRIqs9OzzBesJWMlBZ5Vppb3cJcnd/PQSM1 /luKJWOWGOWae0kpdqEJj7AEsHzACcT/U8SQALoN9v5aG5GKXDsu8ZERHcc7e6Q3KSGzJOV1U +S9/b/52s/paXNV1TbMB1Hewb1zln2LZlInGgGiSrNncdexuFpcB9CO1/fxCkWhwMqQo9g1Or O9jlNwhhqkob7nUbr8SsOLfBdgIXsHYlXD28igt8UODIC2MA2fd1fTlbNFRaYugxHcOxuOT53 2P/z6Gfcy+hJv1XAY2rmBwCC7uVP9Qammgvz7K4Ck8Np41HG1FXLKzQ/2xx//Bxs/kdpZjnLX aP1k7BQRKHiItcZvYyKn+64ttwoXGiWWnt+9t5za3eYX5y+kSBx2/lHKZOOxIa4+W+HPiBLa3 rNho7MfKOX2AtxCU0a91jR6TTEvxB362cZC6+kmL7+Xmf1/+kdtrut3qV1/xvautQXnr6i0OY yse5Obz2vJAwxyETtJK6s49gv9bqAtYi7By2cTLTuUidDNezrQEip8fRkKwH1i+piGLz7c2pG sbgSqoLDYkYmtO0lLWJ0gQ4lZgLbX8pPq00lpVhvnWglSymUil2ujXz6ondNxAAaAZQTvDxNY cksJ5y4BUB6O78+m Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 16 September 2015 21:45:38 WEN Pingbo wrote: > hp_sdc_rtc_proc_show() use timeval to store the time, which will > overflowed in 2038. > > This patch fixes this problem by replacing timeval with timespec64. > hp_sdc_rtc_proc_show() only output string, so that userspace will work > normally if we apply this patch. > > Not all timer in i8042 have y2038 risk(handshake, match timer, etc), > Replacements in those timer are just for consistency. > > Version 2 Updates: > - compiled in m68k gcc cross compiler(4.6.3), no extra warnings > - placed s64 type cast in tv.tv_sec, making sure it work properly in > both 32bit and 64bit platform. > > Signed-off-by: WEN Pingbo > Cc: Y2038 > Looks very good, Reviewed-by: Arnd Bergmann