From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A6172C0F93 for ; Sat, 8 Aug 2026 22:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786228553; cv=none; b=nX0t9BDFIN45pd9V13H1cqDSE23Ml7Ske9BcGVTz/7t6rvuVpC7Xr32UB1UZ/cTreEARqvABG8wgUyCRifk58GEW1alvv/o3JuXdHjAwD6R8pW3QWJ8Oj9wswsiM+ndsrHIBUtmnZwlnQFO0RRZXDR0PgqtopXsuFmqVYB85qnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786228553; c=relaxed/simple; bh=ThsXSy910Kxj+U09LRzpiF8ougdSnR07B8GFSNyb9hE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tXqnjTIwnkUv1Zx6NKYdCVerYkA7qf/2b72Zh/eQiLaJ8/wajqh1xlIYrUehItavodKztRNDnyd3IVK7oH5v0tzhxKCNuulu5v/XqQHjIdhUqu6fqvl02B5kLSpjZ6NtvX5Hlxf09/l6u9YGcIiBmoKfFl2byqiFpq8kBF6KcqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=osuxGL7l; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="osuxGL7l" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-4a46a53abc9so444831b6e.3 for ; Sat, 08 Aug 2026 15:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1786228549; x=1786833349; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yQfW34he5hWnfmFpf7/3FQ0KRYGIGQ/GJRwqEgPg7k8=; b=osuxGL7l32HYiWWk8lOTLuGfIWr4q+DAqz6xjqmg+jiO/uz4S2Pk8CSigfgH2w5SQr MHivnLSutOpDSt7dICGrO3BIzJiAhkR/ruae/gDHDRqTZZ9+zS99R3/opzQdlhF90HcB OpdkeOEyR/UQAK/lGEGx4qSyZUK1NTbiG+oOj2Vu2E9g1P8iCt555iYygL5zAgq3VBRn pWUTLRaUCdgMsnYHpZNTYmUbW/resD5MWqGcGFaTARIdM8gV6zealANbhWzjCb3ZzX43 fJHxeEn69qd4yBUFSRNhESY2P/yLYp+ZClt10bDCypq/DPsaQuwBqEaG0uP22cr18hPP fTlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786228549; x=1786833349; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yQfW34he5hWnfmFpf7/3FQ0KRYGIGQ/GJRwqEgPg7k8=; b=TE2J1plFF/9eOyPYk0VRQb6e2fJqBdwSNyBedTFfZurPa3GYg7sHuRQJNyOCRyh5aL V5O41262qGXaKqbFPjVdD+5/g2Q+QfdJWGf5m1owCmZYdlhfDLNhTUL8h1JUtrpyXCIj Xzrqfar2OZbM65u+lz+dUdQ3boHyYdCzqGC2kxWZ6pHQRp56pJBn8EgHXRZt5HjLPgO9 sQB0BUb5E6tAC3SmJRMffDcmYYccQiUTVnJZwgZDP9KHGTDoVcjJkZJ4UFQ+HUvapLqW QBFf5wbm4Lq1PHhc0uJurIoFZIurotUNOOr0MUFUnmjVViXNrU54gGaWRgeFOUHOTYjW oulg== X-Forwarded-Encrypted: i=1; AHgh+Ro+m3UKJjNG8/i59Er4V0fYiQnkSkAxjijYGtJoKkcl5TflbMsdaCn9aODtLZUneR6v1TQWJ26404QzqjI=@vger.kernel.org X-Gm-Message-State: AOJu0YyfRNjExECnoPJUQ894I2tjopu0uUb69nujRnSj3BJMB1LqRePo CatWd9OXOk3SDSEtRVv7ywG1VNYjnqcRov2D4JNiP+XKh0Wcgo8ow2Wu7BaCf88EV+k= X-Gm-Gg: AR+sD10JkALQSDZ6ZdV2++gX7NVXeyuT8E7UaQJ4baandEn81IPZDkWBilAIMl1qJf1 Scz/K09eqrxBBi3iPuhkC8u1Zw+/n9Z4mm/RQxBxR92mEnmDeUX7FH0LvC4ID06zvL4QxyUNirg OvyDtIheAcyBhvCsvbXcLaaDA8z9hJaTX726yoC5hhQQF3XnUhxvPoZ7Rz2oX7TrbRmJHApi3cS 24xhT9MZfnknYKYDJl4QyOvfv4EpkxY/3n+rSd8+MuPRKEZ2kpkjBaYxi8qXPgGeEhMNp+Dj2jc /Q73D87bVbgX0EklC0bKOYmzwz33eAl67lWafNBJunFQxZsu3HB/thO5UlL+n5CAPF0MB+1JJPb pd/gSl5b2antqHK73m7YWw4wwg2nDzvyGum0U0USF95t9YXKm9b7J0l2jjawgX/7Lbs7N7LA+uS bsv1y0oa2sYKcNWnAFO51dMqA29GFu5YweugN9/RH+4WATLriLNiRhAYDFvkPYR9XCkx0jzUwOZ VFm1DadA0ED5pqHaZgHuMxigJfH/9Ulaqyh+Gw= X-Received: by 2002:a05:6808:191b:b0:4aa:cad:cb4c with SMTP id 5614622812f47-4b13317f7ccmr10407933b6e.1.1786228549426; Sat, 08 Aug 2026 15:35:49 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:99c2:f16e:201c:3bb5? ([2600:8803:e7e4:500:99c2:f16e:201c:3bb5]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4b1af63b441sm2919282b6e.14.2026.08.08.15.35.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Aug 2026 15:35:47 -0700 (PDT) Message-ID: <261dcaa5-3e9f-4da8-adb9-dae4eb7310f2@baylibre.com> Date: Sat, 8 Aug 2026 17:35:45 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: accel: bmc150: use IIO_DECLARE_BUFFER_WITH_TS To: Yash Suthar , Jonathan Cameron Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260808220236.421832-1-yashsuthar983@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260808220236.421832-1-yashsuthar983@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/8/26 5:02 PM, Yash Suthar wrote: > Replace bmc150_accel_data plain buffer with > IIO_DECLARE_BUFFER_WITH_TS() that also keep > timestamp aligned. Please don't wrap the lines so short. In git commits we usually aim for 76 columns, IIRC. > > Signed-off-by: Yash Suthar > --- > drivers/iio/accel/bmc150-accel.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/bmc150-accel.h b/drivers/iio/accel/bmc150-accel.h > index e8f26198359f..e0773533efeb 100644 > --- a/drivers/iio/accel/bmc150-accel.h > +++ b/drivers/iio/accel/bmc150-accel.h > @@ -64,7 +64,7 @@ struct bmc150_accel_data { > struct bmc150_accel_trigger triggers[BMC150_ACCEL_TRIGGERS]; > struct mutex mutex; > u8 fifo_mode, watermark; > - s16 buffer[8]; > + IIO_DECLARE_BUFFER_WITH_TS(s16, buffer, 3); > /* > * Ensure there is sufficient space and correct alignment for > * the timestamp if enabled Probably also needs fixes tag since the old array was not properly aligned. And as a follow-up task (in a separate patch), we can look at replacing iio_push_to_buffers_with_timestamp() with iio_push_to_buffers_with_ts() in this driver. Should be trivial in this case.