From: Keith Owens <kaos@ocs.com.au>
To: linux-kernel@vger.kernel.org
Subject: modversions.h source pollution in 2.4
Date: Mon, 05 Feb 2001 11:07:19 +1100 [thread overview]
Message-ID: <26206.981331639@kao2.melbourne.sgi.com> (raw)
The following files explicitly include linux/modversions.h. They
should not do this, the Makefiles are responsible for automatically
including modversions.h. Since modversions.h will disappear in 2.5,
consider this advance warning that the offending sources can expect
problems.
Maintainers: please fix these sources by removing modversions.h.
arch/ia64/kernel/palinfo.c
drivers/char/amiserial.c
drivers/char/dtlk.c
drivers/char/ip2.c
drivers/char/ip2main.c
drivers/char/rocket.c
drivers/char/serial.c
drivers/md/lvm.c
drivers/net/eepro100.c
drivers/net/epic100.c
drivers/net/starfire.c
drivers/net/wan/lmc/lmc_main.c
The presence of symbols like foo__ver_foo is not a reason to explicitly
include modversions.h, see http://www.tux.org/lkml/#s8-8.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next reply other threads:[~2001-02-05 0:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-05 0:07 Keith Owens [this message]
2001-02-05 0:12 ` modversions.h source pollution in 2.4 Jeff Garzik
2001-02-05 18:16 ` Andreas Dilger
2001-02-05 18:21 ` Alan Cox
2001-02-05 20:23 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26206.981331639@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox