The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: Mark Brown <broonie@kernel.org>
Cc: kuninori.morimoto.gx@renesas.com,
	maxime.ripard@free-electrons.com, wens@csie.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [BUG] Kernel crash on Allwinner H3 due to sound core changes
Date: Mon, 05 Mar 2018 22:30:23 +0100	[thread overview]
Message-ID: <26212674.B0xcQEiVyd@jernej-laptop> (raw)
In-Reply-To: <20180302124050.GF6255@sirena.org.uk>

Hi,

Dne petek, 02. marec 2018 ob 13:40:50 CET je Mark Brown napisal(a):
> On Thu, Mar 01, 2018 at 11:23:57PM +0100, Jernej Škrabec wrote:
> > I removed parts of the code from the sun4i codec driver and interestingly
> > it doesn't crash if I remove following lines:
> > 
> > ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
> > if (ret) {
> > 
> > 	dev_err(&pdev->dev, "Failed to register against DMAEngine\n");
> > 	goto err_assert_reset;
> > 
> > }
> > 
> > Is it possible that NULL pointer causes troubles somewhere down the line?
> 
> Shouldn't be, that's just the configuration which is optional and not
> what we're crashing trying to register, we can mostly configure things
> by querying the capabilities of the DMA controller via the dmaengine API
> these days.  You're removing all the DMA support there so cutting out a
> huge segment of the initialization of both this driver and the machine
> driver.  Other sunxi devices seem to be starting happily in -next so
> there's something system dependent here...

I enabled memory debugging and it seems that there is an issue caused by 
loading sun4i-codec driver and it is somehow connected to 
snd_dmaengine_pcm_unregister().

Here is relevant dmesg: https://pastebin.com/raw/80K9GPnB

Does this tell anything?

Best regards,
Jernej

  reply	other threads:[~2018-03-05 21:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 21:02 [BUG] Kernel crash on Allwinner H3 due to sound core changes Jernej Škrabec
2018-03-01  1:49 ` Kuninori Morimoto
2018-03-01 22:23 ` Jernej Škrabec
2018-03-02 12:40   ` Mark Brown
2018-03-05 21:30     ` Jernej Škrabec [this message]
2018-03-07 21:11       ` Jernej Škrabec
2018-03-08  1:21         ` Kuninori Morimoto
2018-03-08  6:03           ` [alsa-devel] " Jernej Škrabec
2018-03-08 11:13           ` Mark Brown
2018-03-08 23:49             ` Kuninori Morimoto
2018-03-09  6:33               ` [alsa-devel] " Jernej Škrabec
2018-03-09 11:14               ` Mark Brown
2018-03-19  8:08               ` Applied "soc-core: don't call kfree() for component" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26212674.B0xcQEiVyd@jernej-laptop \
    --to=jernej.skrabec@siol.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox