From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v3 11/14] nubus: Rename struct nubus_dev
Date: Tue, 05 Dec 2017 14:50:55 +0100 [thread overview]
Message-ID: <2621660.olL7LkYlpq@amdc3058> (raw)
In-Reply-To: <60d598946ac219440cbb1fabed05964e806ebc5f.1512454057.git.fthain@telegraphics.com.au>
On Tuesday, December 05, 2017 01:20:02 AM Finn Thain wrote:
> It is misleading to call a functional resource a "device". In adopting
> the Linux Driver Model, the struct device will be embedded in struct
> nubus_board. That will compound the terminlogy problem because drivers
> will bind with boards, not with functional resources. Avoid this by
> renaming struct nubus_dev as struct nubus_rsrc. "Functional resource"
> is the vendor's terminology so this helps avoid confusion.
>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Tested-by: Stan Johnson <userm57@yahoo.com>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
for fbdev part
> ---
> drivers/net/ethernet/8390/mac8390.c | 26 ++++----
> drivers/net/ethernet/natsemi/macsonic.c | 22 +++----
> drivers/nubus/nubus.c | 105 ++++++++++++++++----------------
> drivers/nubus/proc.c | 15 ++---
> drivers/video/fbdev/macfb.c | 2 +-
> include/linux/nubus.h | 30 +++++----
> 6 files changed, 98 insertions(+), 102 deletions(-)
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2017-12-05 13:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 6:20 [PATCH v3 00/14] Modernization and fixes for NuBus subsystem Finn Thain
2017-12-05 6:20 ` [PATCH v3 01/14] nubus: Avoid array underflow and overflow Finn Thain
2017-12-05 6:20 ` [PATCH v3 03/14] nubus: Use static functions where possible Finn Thain
2017-12-05 6:20 ` [PATCH v3 02/14] nubus: Fix up header split Finn Thain
2017-12-05 6:20 ` [PATCH v3 10/14] nubus: Rework /proc/bus/nubus/s/ implementation Finn Thain
2017-12-05 6:20 ` [PATCH v3 06/14] nubus: Call proc_mkdir() not more than once per slot directory Finn Thain
2017-12-05 6:20 ` [PATCH v3 04/14] nubus: Fix log spam Finn Thain
2017-12-05 6:20 ` [PATCH v3 11/14] nubus: Rename struct nubus_dev Finn Thain
2017-12-05 13:50 ` Bartlomiej Zolnierkiewicz [this message]
2017-12-05 6:20 ` [PATCH v3 09/14] nubus: Generalize block resource handling Finn Thain
2017-12-05 6:20 ` [PATCH v3 05/14] nubus: Validate slot resource IDs Finn Thain
2017-12-05 6:20 ` [PATCH v3 12/14] nubus: Adopt standard linked list implementation Finn Thain
2017-12-05 13:51 ` Bartlomiej Zolnierkiewicz
2017-12-05 6:20 ` [PATCH v3 07/14] nubus: Remove redundant code Finn Thain
2017-12-05 6:20 ` [PATCH v3 08/14] nubus: Clean up whitespace Finn Thain
2017-12-05 6:20 ` [PATCH v3 14/14] nubus: Add support for the driver model Finn Thain
2017-12-05 8:25 ` Greg Kroah-Hartman
2017-12-07 9:57 ` Philippe Ombredanne
2017-12-10 10:03 ` Finn Thain
2017-12-10 12:08 ` Philippe Ombredanne
2017-12-05 6:20 ` [PATCH v3 13/14] nubus: Add expansion_type values for various Mac models Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2621660.olL7LkYlpq@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox