From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966496AbeAJQpe (ORCPT + 1 other); Wed, 10 Jan 2018 11:45:34 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:45428 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965666AbeAJQpc (ORCPT ); Wed, 10 Jan 2018 11:45:32 -0500 Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Jeremy Linton , Lorenzo Pieralisi , "Rafael J. Wysocki" Subject: Re: [PATCH 2/2] cpufreq: scpi: remove arm_big_little dependency To: Viresh Kumar References: <1515516568-31359-1-git-send-email-sudeep.holla@arm.com> <1515516568-31359-3-git-send-email-sudeep.holla@arm.com> <20180110144631.GE3626@vireshk-i7> From: Sudeep Holla Organization: ARM Message-ID: <2621899b-4c0b-e78d-5432-1993a3d295f1@arm.com> Date: Wed, 10 Jan 2018 16:45:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180110144631.GE3626@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 10/01/18 14:46, Viresh Kumar wrote: > On 09-01-18, 16:49, Sudeep Holla wrote: >> The dependency on physical_package_id from the topology to get the >> cluster identifier is wrong. The concept of cluster used in ARM topology >> is unfortunately not well defined in the architecture, we should avoid >> using it. Further the frequency domain need not be mapped to so called >> "clusters" one to one. >> >> SCPI already provides means to obtain the frequency domain id from the >> device tree. In order to support some new topologies(e.g. DSU which >> contains 2 frequency domains within the physical cluster), pseudo >> clusters are created to make this driver work which is wrong again. >> >> In order to solve those issues and also remove dependency of topological >> physical id for frequency domain, this patch removes the arm_big_little >> dependency from scpi driver. >> >> Cc: "Rafael J. Wysocki" >> Cc: Viresh Kumar >> Signed-off-by: Sudeep Holla >> --- >> drivers/cpufreq/scpi-cpufreq.c | 193 +++++++++++++++++++++++++++++++++++++---- >> 1 file changed, 178 insertions(+), 15 deletions(-) > > Acked-by: Viresh Kumar > Thanks :) -- Regards, Sudeep