From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755863AbcBILEp (ORCPT ); Tue, 9 Feb 2016 06:04:45 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:55450 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752765AbcBILEn (ORCPT ); Tue, 9 Feb 2016 06:04:43 -0500 From: Arnd Bergmann To: Raveendra Padasalagi Cc: Dmitry Torokhov , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonathan Richardson , Jon Mason , Florian Fainelli , Ray Jui , Scott Branden , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH 1/3] input: cygnus-update touchscreen dt node document Date: Tue, 09 Feb 2016 12:04 +0100 Message-ID: <2631849.GeOulu78vx@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1455008277-8312-2-git-send-email-raveendra.padasalagi@broadcom.com> References: <1455008277-8312-1-git-send-email-raveendra.padasalagi@broadcom.com> <1455008277-8312-2-git-send-email-raveendra.padasalagi@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ZWPL/5DxBBm8T7ak63L9fV2la4HYSCqkMgU3qOIBwkI5jDDNfa8 jaenp26SuNA+xWckYQl69l3fniP/qvsXTgDHFi/wMdnJC2RzkJ1iwifkwl4WiQqK78/HvQy 5rBUfp1eSd24rFJDZwTzttr2mD1lbUUtnUClWRlvu1NmiugvWvo8ZgZz80dx/2Kmz7R67ZA uOSDBsFuegteiw4OV977g== X-UI-Out-Filterresults: notjunk:1;V01:K0:+7SI5pszcMY=:pX1DDAs9t4k17u9GKzVPjG h+CS1lqis3UsK5ia+/Zsuyu5SrSk4BFaUwE9m1TxRd7jFCF36+vhqMZyaAWHeGoZB8SVSZQ2I 4IDc5iQ5T+piYKI8MWEDZ1ok3VqbcCnqIus0wGE5ZYz4a8c0gVlGuvnX1U8037LQ9RRWpxG7j 3JbXrcQe1574SBt+0Zmqab91KGVvc8v5cQm2MFdx+VkKNFyjAG5RC/mAPFW0JIZYMoIODwmoO sa+eh83xOiC5G7WccDZ3f1+2mOpO+D19f+O/OaG5vi6TB2sgFHNJ/0IGrZYTP2MjeQa7solEr ZaDxWeQSS7IEEc4odE4iBvb2jwWNDWzY13m6vVNb4886N5HMGFy2uGMA2vrhVOBrnbWSmccBu 6wGk6+fSWdnqYOEXhJX7+VT1gNcmIv5r00Q35aeCn5/SZnZLteBgycfoIW5msI8TdbcXCWolZ VISZb5cUwtKfsEUCRFwlPqJ7RyqrmHZ6LW5z2lCzCjht23lMT0Lwl4ds5EJhml+lsAMDSwiRF oVE7U10vfws3QshI7EJqAlfxMaeqArqro8xXGI1f2zGc+KKqLpUXoEsc7zgasr9ueILjO190i Ft6Rzh+Phi+2JCvAe847cJArZCxJdd2KfXKEXDzbCkWPoKuXp3YHPsJeAXMibS5YQHrxdQyvU RmQwsiTMBzBHt3sEp2/rsbPl7z75t/4me/SGAVBceApxoa2EkRU9EhWhgDbZ2T1d6vljmbVHz p4RxUu66B486Fs3C Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 09 February 2016 14:27:55 Raveendra Padasalagi wrote: > + > +One of the below 2 property is mandatory. > +- ts_syscon: handler of syscon node defining physical base address > + of the controller and length of memory mapped region. > + If this property is selected please make sure MFD_SYSCON config > + is enabled in the defconfig file. > +or > +- reg: physical base address of the controller and length of memory > + mapped region. > + > - clocks: The clock provided by the SOC to driver the tsc > - clock-name: name for the clock > - interrupts: The touchscreen controller's interrupt > @@ -54,12 +62,16 @@ Optional properties: > - touchscreen-inverted-y: Y axis is inverted (boolean) > > Example: > + ts_adc_syscon: ts_adc_syscon@0x180a6000 { > + compatible = "syscon"; > + reg = <0x180a6000 0xc30>; > + }; > > touchscreen: tsc@0x180A6000 { > compatible = "brcm,iproc-touchscreen"; > #address-cells = <1>; > #size-cells = <1>; > - reg = <0x180A6000 0x40>; > + syscon = <&ts_adc_syscon>; > clocks = <&adc_clk>; > clock-names = "tsc_clk"; > interrupts = ; This doesn't seem right: For one thing, it's an incompatible binding change which you should try to avoid. Worse, the syscon has a name indicating that it really has a particular function, but the name is completely generic (just "syscon"). Please add a specific compatible string identifying the device that owns the registers, and put any other associated properties (clocks, interrupts, ...) that are for that device in general rather than just the touchscreen in there. Your changelog text fails to describe why you do this change in the first place, and why you can't do it in a backward-compatible way, so please rewrite that text. Arnd