From: David Howells <dhowells@redhat.com>
To: Michael Bommarito <michael.bommarito@gmail.com>
Cc: dhowells@redhat.com, Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>,
Marc Dionne <marc.dionne@auristor.com>,
linux-afs@lists.infradead.org, Ilya Dryomov <idryomov@gmail.com>,
Xiubo Li <xiubli@redhat.com>,
ceph-devel@vger.kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] crypto: krb5 - filter out async aead implementations at alloc
Date: Fri, 15 May 2026 12:47:05 +0100 [thread overview]
Message-ID: <2632015.1778845625@warthog.procyon.org.uk> (raw)
In-Reply-To: <20260510232455.2245650-1-michael.bommarito@gmail.com>
Michael Bommarito <michael.bommarito@gmail.com> wrote:
> - ci = crypto_alloc_aead(krb5->encrypt_name, 0, 0);
> + ci = crypto_alloc_aead(krb5->encrypt_name, 0, CRYPTO_ALG_ASYNC);
Apologies, but doesn't that do the opposite of what we want?
Documentation/crypto/architecture.rst says:
The mask flag restricts the type of cipher. The only allowed flag is
CRYPTO_ALG_ASYNC to restrict the cipher lookup function to
asynchronous ciphers. Usually, a caller provides a 0 for the mask
flag.
Don't we want only synchronous ciphers?
David