From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B67C433F5 for ; Sat, 25 Sep 2021 09:13:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6CDF61250 for ; Sat, 25 Sep 2021 09:13:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239986AbhIYJPC (ORCPT ); Sat, 25 Sep 2021 05:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234271AbhIYJO4 (ORCPT ); Sat, 25 Sep 2021 05:14:56 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4A92C061570 for ; Sat, 25 Sep 2021 02:13:21 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id dm26so11669305edb.12 for ; Sat, 25 Sep 2021 02:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r4X3zgqJoNQc3RX/YtXmI2AyNwIuqhCGtXgdq74+d/8=; b=YqOudozNjg0sBSf7e6li0FLb3sxy7ozGt59ooI2RIvU8/Koo8rSYFf1Zkq439aaq26 4fz6APCCEhKFytGUSUsowRjlfbB2T4fW602FCETQC0bbRQQeV8AffS76OdYZc0ZMIuQS Tpa280d+VNGTVNFbVqtNZXF2zaJH1013HkdHrUfiVBWLLo9qzh2UsKTrjG9unnH3kpKM IwkZ0rJITkOKpy0O9MlAsO9W8AvClMjcwzzXWbJ45SwvuZVZf5suoW2+b5jzSuYROw8N H3oCgcBluN4Bz+VDoMY2Ww2geX0P5kn0FnZ94ucZWQTnYy5efI/Fx9IpkvrZIXJ9iOMh AkYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r4X3zgqJoNQc3RX/YtXmI2AyNwIuqhCGtXgdq74+d/8=; b=x0cyIyNfD6e6hXYJU7D39Ze5z4wjfEMmHReDRGsN9XIdgQ2/CTMC+TtxqCXL+OLFRg Y3GkMQ6IrjO5MyruP5up3JL1Jjt2Xu+V0VyEtMkee9iUkpEooUwpRxS8UbCbwU9Szy7f KBNS63BbbbOPDRQ5MCgplkGQRZaR1uHGe6IdttnculFVTIRzWcDi0mtMW6FgEVylisFE 6KVAKWj/iN0PvPIi8pjLFo2Q9y7Fg65gg/t0clknxhlV8/WQv1YUj3MpSrC3tXBWuFJm ua4/LMPbRXjkuvKLBWpVIx1rs6zkJezVG37TKOzVlQOhMbG2cbNurDalNMMtuvBQxxlO jAyQ== X-Gm-Message-State: AOAM530urNEop99oBKO4lPixLjB4Uwkb4Au+xY/parhKW+MzhQqUAnog ToUMXFlvKN59mZow6ZQmBXry15KZazQ= X-Google-Smtp-Source: ABdhPJyVp2AzOE3J1rakjH0fen02VuZq18GYfSi89eFcxCu8xNGTx8MCdSBtNJ71OurvRxN870yn+Q== X-Received: by 2002:a50:d9ce:: with SMTP id x14mr5179701edj.175.1632561200328; Sat, 25 Sep 2021 02:13:20 -0700 (PDT) Received: from localhost.localdomain (host-212-171-30-160.retail.telecomitalia.it. [212.171.30.160]) by smtp.gmail.com with ESMTPSA id z24sm453102edr.56.2021.09.25.02.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Sep 2021 02:13:19 -0700 (PDT) From: "Fabio M. De Francesco" To: Tommaso Merciai Cc: tomm.merciai@gmail.com, Forest Bond , Greg Kroah-Hartman , Yujia Qiao , Lucas Henneman , Madhumitha Prabakaran , Marcos Antonio de Jesus Filho , Aldas =?utf-8?B?VGFyYcWha2V2acSNaXVz?= , "Gustavo A. R. Silva" , Deepak R Varma , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] staging: vt6655: replace camel case b_short_slot_time instead of bShortSlotTime. Date: Sat, 25 Sep 2021 11:13:17 +0200 Message-ID: <2635701.kFDcI0R34J@localhost.localdomain> In-Reply-To: <20210925074531.10446-2-tomm.merciai@gmail.com> References: <20210925074531.10446-1-tomm.merciai@gmail.com> <20210925074531.10446-2-tomm.merciai@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, September 25, 2021 9:45:22 AM CEST Tommaso Merciai wrote: > Signed-off-by: Tommaso Merciai > --- > Changes since v2: > - Add changelog. > > Changes since v1: > - Make the commit message more clearer. > --- > drivers/staging/vt6655/baseband.c | 4 ++-- > drivers/staging/vt6655/card.c | 2 +- > drivers/staging/vt6655/device.h | 2 +- > drivers/staging/vt6655/device_main.c | 4 ++-- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/ baseband.c > index f73f3fad3e05..170c4056946f 100644 > --- a/drivers/staging/vt6655/baseband.c > +++ b/drivers/staging/vt6655/baseband.c > @@ -2200,7 +2200,7 @@ bb_set_short_slot_time(struct vnt_private *priv) > > bb_read_embedded(priv, 0x0A, &by_bb_rx_conf); /* CR10 */ Well, it's pretty clear that you didn't read the document whose link you've been provided by Gustavo A.R. Silva and Greg Kroah-Hartman. Furthermore you also ignored Gustavo's suggestions about how a patch should be made. :( If you had read that document you should have noticed that your patches doesn't comply with the Linux kernel development rules. In section "Revising your patches/Versioning one patch revision" there's a sample patch ("fix the number of endpoint parameter"). If you look at that patch you see what your patches are missing. Patches have at least three logical entities, but in your case they must be four because you are sending new versions of the initial one. 1) A "Subject". Along with information about the version and the position in a series, you must always write the subsystem prefix and the driver name. The text in the "Subject" should summarize with _few_ _words_ the "Commit message" or "Changelog". Few words means that you don't need "replace camel case b_short_slot_time instead of bShortSlotTime." because it is too long. No full stop at the end of the line. Just something like "Fix camelcase in bShortSlotTime" is enough (you may also add "[] variable", if you want to. 2) A "Commit message" (or "Changelog"). You must explain "what" you did and "why". You didn't provide it and Greg Kroah-Hartman complained. He won't ever accept patches without it. If you had read "Start creating your first patch / Git post-commit hooks", you would have known of the "post- commit" hook and so, you had not submitted patches without messages because that hook would have warned you. 3) A "Versions list" (or a "List of changes between versions"). Where in the list of 3/3 you recorded that you changed "port_off_set" to "post_offset"? 4) A "diff" of the changes that shows the changes you have made, one line a a time. This is the only part that is not up to you because Git adds it automatically. Again, please read the documentation. Thanks, Fabio