public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH] BUG_ON() not arch-specific.
Date: Wed, 05 Dec 2001 14:42:32 +0000	[thread overview]
Message-ID: <26384.1007563352@redhat.com> (raw)
In-Reply-To: <E16BWQ4-00070r-00@wagner>
In-Reply-To: <E16BWQ4-00070r-00@wagner>


rusty@rustcorp.com.au said:
> --- linux-2.5.1-pre5/include/linux/kernel.h	Wed Dec  5 16:49:14 2001
> +++ working-2.5.1-pre5-percpu/include/linux/kernel.h	Wed Dec  5 18:12:15 2001
> @@ -176,4 +176,5 @@
>  	char _f[20-2*sizeof(long)-sizeof(int)];	/* Padding: libc5 uses this.. */
>  };
>  
> +#define BUG_ON(condition) do { if (unlikely((condition)!=0)) BUG(); } while(0)

You'll need to add #include <linux/compiler.h> to linux/kernel.h if you do 
that. Let's not make the include files any more broken than they already 
are :)


--
dwmw2



  parent reply	other threads:[~2001-12-05 14:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-05  7:24 [PATCH] BUG_ON() not arch-specific Rusty Russell
2001-12-05  8:36 ` Jens Axboe
2001-12-05 14:42 ` David Woodhouse [this message]
2001-12-08 23:56   ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26384.1007563352@redhat.com \
    --to=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox