Re: progs/test_bpf_nf_fail.c:82:4: error: incomplete definition of type 'struct nf_conn'

Daniel Xu
2022-12-14T23:48:21Z

On Mon, Dec 12, 2022, at 1:57 AM, kernel test robot wrote:
> Hi Daniel,
>
> First bad commit (maybe != root cause):
>
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
> commit: e2d75e954c0a277b8fa0ddf666ddd4f9b73195f7 selftests/bpf: Add
> tests for writing to nf_conn:mark
> date: 3 months ago
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> reproduce:
> #
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e2d75e954c0a277b8fa0ddf666ddd4f9b73195f7
> git remote add linus
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout e2d75e954c0a277b8fa0ddf666ddd4f9b73195f7
> make O=/tmp/kselftest headers
> make O=/tmp/kselftest -C tools/testing/selftests
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>>> progs/test_bpf_nf_fail.c:82:4: error: incomplete definition of type 'struct nf_conn'
> ct->status = 0xF00;
> ~~^
> progs/test_bpf_nf_fail.c:7:8: note: forward declaration of 'struct nf_conn'
> struct nf_conn;
> ^
> 1 error generated.
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp
>
> Attachments:
> * config

Not sure what to do about this. Seems like we'd want conditional compilation
for selftests depending on build config. But maybe effort not worth it since
there's a specific CI environment? And unlikely that connmarks disabled on
most distro kernels.

Lemme know if it's worthwhile to fix. Otherwise I will ignore.

Thanks,
Daniel