From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757818AbbBEPAe (ORCPT ); Thu, 5 Feb 2015 10:00:34 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:9988 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757500AbbBEPAc (ORCPT ); Thu, 5 Feb 2015 10:00:32 -0500 X-AuditID: cbfee61b-f79d76d0000024d6-f2-54d3858e6658 From: Bartlomiej Zolnierkiewicz To: Nick Krause Cc: Tejun Heo , linux-ide@vger.kernel.org, "linux-kernel@vger.kernel.org" , One Thousand Gnomes Subject: Re: [PATCH] ata:Remove no longer valid FIXME comment in pata_ninja32.c for the function,ninja32_init_one Date: Thu, 05 Feb 2015 16:00:19 +0100 Message-id: <2643733.MOfu1fua6S@amdc1032> User-Agent: KMail/4.8.4 (Linux/3.2.0-70-generic-pae; KDE/4.8.5; i686; ; ) In-reply-to: References: <1423093661-32188-1-git-send-email-xerofoify@gmail.com> <711574455.M170TblBab@amdc1032> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=UTF-8 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLLMWRmVeSWpSXmKPExsVy+t9jAd2+1sshBrdfcltMmvKXzeLYjkdM Fpd3zWGz+LX8KKPFrymyDqweO2fdZffYtKqTzaP15CZWj8+b5AJYorhsUlJzMstSi/TtErgy evY8YC1YLFWx8N871gbGmyJdjJwcEgImEldu7GCHsMUkLtxbz9bFyMUhJLCIUeLr/vUsEE4L k8S5Wz8ZQarYBKwkJravArNFBFQlnn5dBlbELLCWUaKn4wRQOweHsECxxPo70SA1LEA1y9ct ZQaxeQU0Jb6tug7WKyrgKbFz+gEwm1MgWOLkmkvsEMvWMEr83X4cqkFQ4sfkeywgNrOAvMS+ /VNZIWx1iUnzFjFPYBSYhaRsFpKyWUjKFjAyr2IUTS1ILihOSs810itOzC0uzUvXS87P3cQI DuRn0jsYVzVYHGIU4GBU4uG12HcpRIg1say4MvcQowQHs5II753myyFCvCmJlVWpRfnxRaU5 qcWHGKU5WJTEeZXs20KEBNITS1KzU1MLUotgskwcnFINjCWFiqq+f3iNdT+WLXJ7Y1r7OuZF bfdOD60YyT9X4xZfid1oe0xDzmnh+sQl+nPfs+90ffVh1TIGReOSsNQYSY+69PbSPkmZKQLp Bzdp6VxP1hML5EgtWpnD61vF6dCtffrEqU1ffkpc4/dS2p6bYcdcErhYvk9PPG5J+1Wx2fX+ S/9bst5UYinOSDTUYi4qTgQAuS/K5mACAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, February 05, 2015 08:49:24 AM Nick Krause wrote: > On Thu, Feb 5, 2015 at 8:15 AM, Bartlomiej Zolnierkiewicz > wrote: > > On Thursday, February 05, 2015 08:00:24 AM Nick Krause wrote: > >> On Thu, Feb 5, 2015 at 6:02 AM, Bartlomiej Zolnierkiewicz > >> wrote: > >> > > >> > Hi, > >> > > >> > On Wednesday, February 04, 2015 06:47:41 PM Nicholas Krause wrote: > >> >> Removes the no longer valid fix me comment in the function, ninja32_init_one for > >> >> questioning if we are required to remove the activated device at the end of this > >> >> function by calling the function, ata_host_activate to activate the device passed > >> >> by the caller of the function ninja_init_one. This comment is no longer needed as > >> >> we need to deallocate the memory used to store this device's information when the > >> >> device is no longer in use by the system in order to avoid leaking memory. Due to > >> >> this the driver in the file,ninja32_init_one has the function,ata_pci_remove_one > >> >> to release the memory allocated in it's init function and therefore this comment > >> >> can now be removed due to use correctly freeing the memory allocated from the > >> >> driver's init function,ninja32_init_one. > >> >> > >> >> Signed-off-by: Nicholas Krause > >> >> --- > >> >> drivers/ata/pata_ninja32.c | 1 - > >> >> 1 file changed, 1 deletion(-) > >> >> > >> >> diff --git a/drivers/ata/pata_ninja32.c b/drivers/ata/pata_ninja32.c > >> >> index efb272d..47b30d3 100644 > >> >> --- a/drivers/ata/pata_ninja32.c > >> >> +++ b/drivers/ata/pata_ninja32.c > >> >> @@ -147,7 +147,6 @@ static int ninja32_init_one(struct pci_dev *dev, const struct pci_device_id *id) > >> >> ap->pflags = ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE; > >> >> > >> >> ninja32_program(base); > >> >> - /* FIXME: Should we disable them at remove ? */ > >> > > >> > After looking at the driver history I think that the comment is about > >> > ninja32_program() enabling interrupt lines (which don't get disabled when > >> > the host controller is detached from the driver) not about the cleanup > >> > done during ata_pci_remove_one(). Alan, is this correct? > >> > > >> >> return ata_host_activate(host, dev->irq, ata_bmdma_interrupt, > >> >> IRQF_SHARED, &ninja32_sht); > >> >> } > >> > > >> > Best regards, > >> > -- > >> > Bartlomiej Zolnierkiewicz > >> > Samsung R&D Institute Poland > >> > Samsung Electronics > >> > > >> If that is the case then I will disable the interrupt lines for the > >> host in this driver's > >> remove function. > > > > Unless you have hardware to test such change (to check that there are no > > side-effects) just moving FIXME to ninja32_program() seems to be a better > > approach for now.. > > > > Best regards, > > -- > > Bartlomiej Zolnierkiewicz > > Samsung R&D Institute Poland > > Samsung Electronics > > > Very well I will send in a patch moving this fix me. Please wait with this to give a chance for somebody more familiar with pata_ninja32 driver/hardware to comment on it. There is absolutely no need to rush with this change.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics