From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934661AbcAZPTB (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Jan 2016 10:19:01 -0500
Received: from mout.kundenserver.de ([212.227.126.131]:64237 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932442AbcAZPS7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Jan 2016 10:18:59 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, linux-arm-kernel@lists.infradead.org,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Andreas Fenkart <afenkart@gmail.com>, Tony Lindgren <tony@atomide.com>,
        Roger Quadros <rogerq@ti.com>, linux-mmc@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: omap_hsmmc: don't print uninitialized variables
Date: Tue, 26 Jan 2016 16:18:25 +0100
Message-ID: <26439572.8QBco8eDYu@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <56A78838.3050400@ti.com>
References: <1453737031-1959584-1-git-send-email-arnd@arndb.de> <56A78838.3050400@ti.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:VJ+UAcCh7WBzvTV1LB3lZWvrLjs65saYkDLMqd/cZ53sOYRtGxO
 KIKtgve5A6MTTjIohkvv5ij5pOFqz2Sz72j2fEIvhLgJZflCvlaLMUtgHwsMHzjWGG4RT4q
 IR2pXWxykpa0xN0HDUBoIWdniQJjJ1ddbUhwTfJ1vUReDbNBRkISPwd3EJer602Ar1ERJWm
 V5llcYYUDEEeMMAqxCYzQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Z6oe+bOh2Eo=:nXs0i1qFXYQ48IwKtCwyHI
 rGNmwE4H3v/2Gm9jcuHYkJmL2EXLnsm7lYdkTNf5GebcNx40FYtn3ly1qiL+bs1Ppn9kzEDG+
 DFtqXQv/GTzBUyqSKz3AyKVvHvgOy5WtnntfaxLY1qbaVe6bgzPbM6qbMz62gDYAL6y/a1Np4
 hqb1b52AslcKdXnGm7DP99GJ3fr+CVpIl8ghVtH13JrnVYqE2RBBlJxoqjs/GuXwqwBtqpnyp
 00pYkeBn6BYNykxf/yjUrOX6BD3NHVQkt1GOH3fvJzj5EWHbOoS9H9goH6h51dx6k2jxGv9lB
 WZE9XHAAx8ZdB+R1D+gr9JUbcSoPB0Sa+UBFnKf8aaikbtTtHfoATx144HWtj0KAYirTk/Ji5
 kr865NDQs14NOblWEW/7ALwbfMVrGaTFShrGpqwUIx7SG9BGRqdBl8vlEQpBUEfbPP5lJm1Jr
 aePca06uaPf3bG04gf/SZJHrzGfgXuBzIA8HeGg1NPdXaeUv/uy4hGY89XiG+W3DAvYMbGByZ
 kYB8/Id8C4VJ3spYgGrAWXm4j7rP7aWfHTKuAGHtui/I6iP3MkXT9jybriKFCZlo29MxxRQEy
 cusFSlmDNsPETB8cQpvcxDeY76pVuiuzFWkyA21JHpEY8ZuvNJSgIIa/TdpmL0H/M3pePF64F
 ZFGt4rfu8cONGuwSRk1p1HWdUSAbOug40sisx4g+qdu6ZkfNiwEIy90Asg3BEfcSq9dWIcsAI
 pThxvrhpUl3g9lOC
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 26 January 2016 16:52:40 Peter Ujfalusi wrote:
> > @@ -2133,7 +2131,17 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
> >  
> >       omap_hsmmc_conf_bus_power(host);
> >  
> > -     if (!pdev->dev.of_node) {
> > +     host->tx_chan = dma_request_slave_channel(&pdev->dev, "tx");
> > +     host->rx_chan = dma_request_slave_channel(&pdev->dev, "rx");
> > +     if (!host->tx_chan || !host->rx_chan) {
> 
> While it is really unlikely that we are failing to get only one of the
> channels... It means anyway that the omap_hsmmc is not usable, but we will
> still try to get via legacy mode and there is a chance that we might get some
> channel.
> 
> Too bad that I can not send the conversion to dma_request_chan() yet due to
> missing things in arch...
> 
> It might be simpler to just remove the printout of the rx/tx_req from the
> dev_err() when reporting failed channel requests...

Fine with me too, I'll send that patch as well and let Ulf pick.

	Arnd