public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: dhowells@redhat.com, James Morris <james.l.morris@oracle.com>,
	serge@hallyn.com, keyrings@linux-nfs.org,
	linux-security-module@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: security: oops on boot in __key_link_begin
Date: Mon, 28 Jul 2014 12:32:12 +0100	[thread overview]
Message-ID: <26466.1406547132@warthog.procyon.org.uk> (raw)
In-Reply-To: <53D31D16.1030806@oracle.com>

Sasha Levin <sasha.levin@oracle.com> wrote:

>   23:	49 89 9f f0 00 00 00 	mov    %rbx,0xf0(%r15)
>   2a:	55                   	push   %rbp
>   2b:*	c1 b8 42 ff 49 8b 5f 	sarl   $0x5f,-0x74b600be(%rax)		<-- trapping instruction
>   32:	10 49 8d             	adc    %cl,-0x73(%rcx)

I can't make any sense of this.  It doesn't look anything like what I
get when I disassemble assoc_array_insert().  There are no SARL or ADC
instructions.

Can you load your vmlinux into gdb and disassemble the function that holds the
faulting instruction:

	gdb vmlinux
	(gdb) disassemble <RIP-value>

Unfortunately, I'm not sure what the RIP value actually is because it's been
replaced in the dump by source file + line number.  It's not this:

	[   31.330473] CR2: ffffffff8b49ff42

though.  That's RAX (ie. 0) plus the offset in the following instruction:

	sarl   $0x5f,-0x74b600be(%rax)		<-- trapping instruction

David

  parent reply	other threads:[~2014-07-28 11:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-26  3:14 security: oops on boot in __key_link_begin Sasha Levin
2014-07-28 11:10 ` David Howells
2014-07-28 11:32 ` David Howells [this message]
2014-07-28 14:49   ` Sasha Levin
2014-07-28 15:01     ` David Howells
2014-07-28 15:37       ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26466.1406547132@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=james.l.morris@oracle.com \
    --cc=keyrings@linux-nfs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox