From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936456AbcJ0NvE (ORCPT ); Thu, 27 Oct 2016 09:51:04 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:52922 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936391AbcJ0NvB (ORCPT ); Thu, 27 Oct 2016 09:51:01 -0400 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Oleg Drokin , Patrick Farrell , lustre-devel@lists.lustre.org, Bobi Jam , James Simmons , Olaf Weber , James Simmons , Jinshan Xiong , "John L . Hammond" , Liang Zhen , Andreas Dilger , Shivani Bhardwaj , Andriy Skulysh , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: lustre: remove broken dead code in cfs_cpt_table_create_pattern Date: Thu, 27 Oct 2016 15:36:04 +0200 Message-ID: <2652666.mQoRF2ExRO@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20161027131242.GA11187@kroah.com> References: <20161025212310.2346367-1-arnd@arndb.de> <20161027131242.GA11187@kroah.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:B1E583asvxI6Xxo4gVGo9rC53ATHFMRI+gIH+jwJIE38i58YKXk IW75mKOcpNFSVHY3+nN4usjmw2/4v3ihA+IWA6wuyKTZCNfResJf8nSE39hHwnkTU0eSuyP vvd0qDzo8t49Z9sgYtxEiBVITh0Cxfh9/2x3oxTC3mRUFU1AzVQQxL3q6SV/iGc43Rj5B/8 WtMw0McYnLehAiHz7Y3kA== X-UI-Out-Filterresults: notjunk:1;V01:K0:y52gDljGYLo=:/q7dEBClc2mGPCtTIeVG/Y dkWHgpVx52vKvUuH27qNB5UK3MOMUgqMQaAmZNK0Dwwczclzp6R2buXv1+2r6ZSKgE8W9fbHD s1A3vZcQNGxIfGZ5z4rXvV0p+rh5zXNb2RPZdax8XxTV+bHQ92uDYilgrfe84hu1RJsKRb7XY wnfheY63xmqq1KjQEGtFXm47TShfhWnhDbUmzHf7S61wDyEuhiAo/Zy1UmElouzNDIyyaf6Tc QpCR053J73JN6ggtMIiZrHGNx5sul6o8Hoz9dImGlAXqznSWJ9s7qh964i940GkUd9y61XUGt D9aB8ova/c3bsjeHRQA2s7bmnWXi+zVNERKbRd89aBSKsgOh9BUWMD1wV7lUe2O7jOIBS8z8f i5v5VdL8BMqqi/RbtZIEb1abEwf394NgAc0T4L/sW52SIdabLPg23FP/N1iCs2MOzftx2sdKw o71eEBEwS4bXkHCd/yF0KbxaVewLEa5CLOt6w+GcBsmHr2Xd/dIyiRfNW0mbGTqPawCL6yl7m ewYHpV/i0k8LDGbNoWHtiypIi6DGMf236RJY49t1wrCy7pZrBZ9OzAErGqumZEojvkmeWMjUp GjCoW5LhdLd7VaE+Dm/o7pM2X//ZBdhcwpbBlyFADZHH5Nb+YTjp37ZbwxUcTi1BOK0mZuU6s EW89nj2K9LYlKgGMHz1bkd5g8E8EJklo2+ykpmWBStOrf2HEoOyjT5Xq6QbPeNZWrTbzNLoOA zOMJauYOUf6NNde2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, October 27, 2016 3:12:42 PM CEST Greg Kroah-Hartman wrote: > On Tue, Oct 25, 2016 at 11:22:30PM +0200, Arnd Bergmann wrote: > > After a recent bugfix, we get a warning about the use of an uninitialized > > variable: > > > > drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c: In function 'cfs_cpt_table_create_pattern': > > drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c:833:7: error: 'str' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > > > This part of the function used to not do anything as we would reassign > > the 'str' pointer to something else right away, but now we pass an > > uninitialized pointer into 'strchr', which can cause a kernel page fault > > or worse. > > > > Fixes: 239fd5d41f9b ("staging: lustre: libcfs: shortcut to create CPT from NUMA topology") > > Signed-off-by: Arnd Bergmann > > --- > > drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 7 ------- > > 1 file changed, 7 deletions(-) > > Hm, I already applied the v1 versions of these, right? What changed > with these, they seem identical to me... The patches you applied were fine, they just had not made it into linux-next by Tuesday, and I thought they got lost as I had sent them as part of a longer series and I screwed up one of the two changelogs initially (you applied the fixed v2 patch I sent immediately afterwards). Sorry about the confusion. Arnd