From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938941AbcIHNAJ (ORCPT ); Thu, 8 Sep 2016 09:00:09 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:56977 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934510AbcIHNAH (ORCPT ); Thu, 8 Sep 2016 09:00:07 -0400 From: Arnd Bergmann To: Yuval Mintz Cc: Baoyou Xie , David Miller , Dept-Eng Everest Linux L2 , netdev , linux-kernel , "xie.baoyou@zte.com.cn" , Ariel Elior Subject: Re: [PATCH v2] qed: mark symbols static where possible Date: Thu, 08 Sep 2016 15:00:22 +0200 Message-ID: <2655062.3nWxjufk2r@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1473323117-8772-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:lxJf3G0NO/alCItBLZyH3TXhlsfrpemZlFwOVU37/tIWMRxOWsy VC8Jl0mkpgRHBSulb8HF5PHqBfc54AtOXDoHuf2wBmxqhbscmP9nNWjk2X7sa/f0LhLgA2d hzzrL3zJdHeD6m6+Q2mhvlKDDwMwMdVrQ8AB76AmyQQcXnhqlweVSElCtjsk8yO8YtpgCo9 6lQ1jCYcI2cmO3b7KTqSw== X-UI-Out-Filterresults: notjunk:1;V01:K0:k1lyixtINck=:9u2PMIj1kKIayrB0aJXdMP HoUhGRDTAjV3WAhOeFHiJhA2QCANdw+28eNEIX+NxWXRelJJcPIcEAuHKi7ecd25vgjuACQV5 nnRJVce0BKKV9bFlLszBO5jxw/Zs69v10/qzIwE4G8uEdi2kn7XcFq5ON9+TohpcUpzCClmZH Cf3R/EQ37copSy0XZc7dxjHKLNOY6JEpnWsYdJfFE3VEVpSgXWVrw7Ye/6sxjxTRVnmhmLybl ynrhSkHMncWjcLJtfXv/4r7LeIO7n+9IrqSHX9D517zDE+8CkGYd4EJsRGxWNK7zmWVi1C8rG 2Rxi8EYH2RBWk5Ryle3+TwU/wDU5z3BGYObx9SKd6CbgyEfMnjryD0uV5g9AerF+ILyaW1Izs 6KkG2XF5XgwF4tsU2E17dd7ZvfgX+ZJ1cFvtXvATxvfkB4ErjeLIxYmH4ZRjIaXNE1HmHYiag xiB3vqpxt0rnefsY1UZX2Hg4R+BN+Xj7FH9w7AXRdq0sNbCRwt14tfoXziQnyHxMDlxsaIY9B 9Ecb9vb5Lvb9tkG3WlQdwbiMYFreWuyyrntMr2UVDoYRHAGFO5G6Vq2DFvQI06PLznGeKnfVf PSbFZho20E+mLcqw2ZKVlXDzzhsA3p3y8YXfIHO06my/7E2v0bKnqvtJCPyI6jFT2E77ykG3V PKwZso9n5NTNznHgNe2T7efIOM7WBNyewXfTtxLn2Itk/Mf9I8NqmnZOUEsIbHstVeXyTB0U8 GSSTH8vmKdSME9Pu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 8, 2016 12:37:13 PM CEST Yuval Mintz wrote: > > 1. qed_get_vport_stats() is in use in net-next by qed_main.c starting > > with > > 6c75424612a7 ("qed: Add support for NCSI statistics."), so we > > shouldn't make it static. > > Besides, it still doesn't apply to net-next > [as net-next has function declaration as a single liner]. Baoyou, I recommended earlier that you start the work on a mainline kernel, but in particular for fast-moving subsystems it is better to use linux-next as the base. This means rebasing your patches every day before sending out stuff, which is some extra work, but you have a much better chance of the patches actually applying to the respective subsystem maintainer trees. It also helps to see if a particular file you are changing was modified in linux-next. The trick I use for that is $ git log --oneline --no-merges torvalds/master..next/master drivers/net/ethernet/qlogic/qed | head e0971c832af4 qed*: Add support for the ethtool get_regs operation c965db444629 qed: Add support for debug data collection 72e8d5fdf58b qed: add missing header dependencies 4102426f9b7b qed: Add infrastructure for debug data collection 2591c280c375 qed: Remove OOM messages 561ed23331df qed: fix kzalloc-simple.cocci warnings c5e801dac4da qed: Clear dcbx memory buffers before the usage. 5ec5dfa4d294 qed: Set selection-field while configuring the app entry in ieee mode. 5fe118c9fd6b qed*: Disallow dcbx configuration for VF interfaces. b0bccb69eba3 qed: Change locking scheme for VF channel followed by looking at who merged the top commit $ git log --ancestry-path --oneline --merges e0971c832af4..next/master | tail 7a700727059a Merge remote-tracking branch 'mtd/master' d7445193092f Merge remote-tracking branch 'rdma/for-next' 9ecd4508b2e9 Merge remote-tracking branch 'mac80211-next/master' b74f90413edd Merge remote-tracking branch 'bluetooth/master' dc9e43436ac5 Merge remote-tracking branch 'wireless-drivers-next/master' ae8d88338957 Merge remote-tracking branch 'ipvs-next/master' 1e786a88da29 Merge remote-tracking branch 'netfilter-next/master' 3a883dcccac5 Merge remote-tracking branch 'ipsec-next/master' bef876902277 Merge remote-tracking branch 'net-next/master' e6f3f120827c Merge branch 'qed-debug-data-collection' which tells you that it came from a branch called qed-debug-data-collection into net-next and from there into linux-next. Arnd