Re: [PATCH] btrfs: Convert zlib_compress_pages() to use kmap_local_page()

David Sterba
2022-07-07T21:22:28Z

On Mon, Jun 27, 2022 at 06:33:05PM +0200, Fabio M. De Francesco wrote:
> The use of kmap() is being deprecated in favor of kmap_local_page(). With
> kmap_local_page(), the mapping is per thread, CPU local and not globally
> visible.
>
> Therefore, use kmap_local_page() / kunmap_local() in zlib_compress_pages()
> because in this function the mappings are per thread and are not visible
> in other contexts. Furthermore, drop the mappings of "out_page" which is
> allocated within zlib_compress_pages() with alloc_page(GFP_NOFS) and use
> page_address() (thanks to David Sterba).
>
> Tested with xfstests on a QEMU + KVM 32-bits VM with 4GB of RAM booting
> a kernel with HIGHMEM64G enabled. This patch passes 26/26 tests of group
> "compress".
>
> Cc: Qu Wenruo <wqu@suse.com>
> Suggested-by: David Sterba <dsterba@suse.com>
> Suggested-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>

Added to the kmap patch queue, thanks.