From: David Howells <dhowells@redhat.com>
To: Eugene Teo <eugeneteo@kernel.sg>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/afs/flock.c: posix_test_lock() returns void
Date: Thu, 19 Jul 2007 13:55:26 +0100 [thread overview]
Message-ID: <26568.1184849726@redhat.com> (raw)
In-Reply-To: <20070719090620.GA14799@kernel.sg>
Eugene Teo <eugeneteo@kernel.sg> wrote:
> posix_test_lock() returns void, so there is no need to test the return value.
> Checking fl->fl_type for F_UNLCK instead.
Yep, thanks. Andrew Morton already has a patch for this.
David
prev parent reply other threads:[~2007-07-19 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 9:06 [PATCH] fs/afs/flock.c: posix_test_lock() returns void Eugene Teo
2007-07-19 12:55 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26568.1184849726@redhat.com \
--to=dhowells@redhat.com \
--cc=eugeneteo@kernel.sg \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox