From: Luca Weiss <luca@z3ntu.xyz>
To: linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Cc: ~postmarketos/upstreaming@lists.sr.ht,
Rayyan Ansari <rayyan@ansari.sh>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rayyan Ansari <rayyan@ansari.sh>
Subject: Re: [PATCH 1/3] ARM: dts: qcom: pm8226: sort includes alphabetically and nodes by address
Date: Mon, 26 Dec 2022 13:08:52 +0100 [thread overview]
Message-ID: <2659686.mvXUDI8C0e@g550jk> (raw)
In-Reply-To: <20221223193403.781355-2-rayyan@ansari.sh>
On Freitag, 23. Dezember 2022 20:34:01 CET Rayyan Ansari wrote:
> Sort the includes and nodes for consistency.
>
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-pm8226.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi
> b/arch/arm/boot/dts/qcom-pm8226.dtsi index 9b7d9d04ded6..d99532ea70b2
> 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: BSD-3-Clause
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/spmi/spmi.h>
> -#include <dt-bindings/iio/qcom,spmi-vadc.h>
>
> &spmi_bus {
> pm8226_0: pm8226@0 {
> @@ -41,13 +41,6 @@ smbb: charger@1000 {
> chg_otg: otg-vbus { };
> };
>
> - rtc@6000 {
> - compatible = "qcom,pm8941-rtc";
> - reg = <0x6000>, <0x6100>;
> - reg-names = "rtc", "alarm";
> - interrupts = <0x0 0x61 0x1
IRQ_TYPE_EDGE_RISING>;
> - };
> -
> pm8226_vadc: adc@3100 {
> compatible = "qcom,spmi-vadc";
> reg = <0x3100>;
> @@ -81,6 +74,13 @@ adc-chan@f {
> };
> };
>
> + rtc@6000 {
> + compatible = "qcom,pm8941-rtc";
> + reg = <0x6000>, <0x6100>;
> + reg-names = "rtc", "alarm";
> + interrupts = <0x0 0x61 0x1
IRQ_TYPE_EDGE_RISING>;
> + };
> +
> pm8226_mpps: mpps@a000 {
> compatible = "qcom,pm8226-mpp", "qcom,spmi-
mpp";
> reg = <0xa000>;
next prev parent reply other threads:[~2022-12-26 12:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 19:34 [PATCH 0/3] ARM: dts: qcom: pm8226: style fixes and new nodes Rayyan Ansari
2022-12-23 19:34 ` [PATCH 1/3] ARM: dts: qcom: pm8226: sort includes alphabetically and nodes by address Rayyan Ansari
2022-12-26 12:08 ` Luca Weiss [this message]
2022-12-23 19:34 ` [PATCH 2/3] ARM: dts: qcom: pm8226: add PON device node along with resin sub-node Rayyan Ansari
2022-12-26 12:11 ` Luca Weiss
2022-12-23 19:34 ` [PATCH 3/3] ARM: dts: qcom: pm8226: add IADC node Rayyan Ansari
2022-12-26 12:14 ` Luca Weiss
2022-12-29 3:34 ` Bjorn Andersson
2022-12-29 3:45 ` [PATCH 0/3] ARM: dts: qcom: pm8226: style fixes and new nodes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2659686.mvXUDI8C0e@g550jk \
--to=luca@z3ntu.xyz \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rayyan@ansari.sh \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox