From: Markus Elfring <Markus.Elfring@web.de>
To: Qiushi Wu <wu000273@umn.edu>, Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: oss-drivers@netronome.com, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Kangjie Lu <kjlu@umn.edu>
Subject: Re: [PATCH v3] nfp: abm: Fix incomplete release of system resources in nfp_abm_vnic_set_mac()
Date: Mon, 4 May 2020 08:01:59 +0200 [thread overview]
Message-ID: <265a25f7-6ef1-1387-d60a-9ffe8ccfbd73@web.de> (raw)
In-Reply-To: <20200503204932.11167-1-wu000273@umn.edu>
> … Thus add a call of the function
> “nfp_nsp_close” for the completion of the exception handling.
I suggest to mention also the addition of a jump target because of
a Linux coding style concern.
…
> +++ b/drivers/net/ethernet/netronome/nfp/abm/main.c
…
> @@ -300,12 +297,16 @@ nfp_abm_vnic_set_mac(struct nfp_pf *pf, struct nfp_abm *abm, struct nfp_net *nn,
…
> +generate_random_address:
> + eth_hw_addr_random(nn->dp.netdev);
> + return;
> }
…
I recommend to apply the check “RETURN_VOID” once more.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=0e698dfa282211e414076f9dc7e83c1c288314fd#n4866
Regards,
Markus
next prev parent reply other threads:[~2020-05-04 6:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 20:49 [PATCH v3] nfp: abm: Fix incomplete release of system resources in nfp_abm_vnic_set_mac() wu000273
2020-05-04 6:01 ` Markus Elfring [this message]
2020-05-04 7:34 ` Markus Elfring
2020-05-04 17:03 ` Jakub Kicinski
[not found] ` <CAMV6ehFC=efyD81rtNRcWW9gbiD4t6z4G2TkLk7WqLS+Qg9X-Q@mail.gmail.com>
2020-05-04 20:13 ` [v3] " Markus Elfring
[not found] ` <CAMV6ehE=GXooHwG1TQ-LZqpepceAudX=P63o139UgKG7TMRxwQ@mail.gmail.com>
2020-05-05 5:48 ` Markus Elfring
[not found] ` <CAMV6ehEP-X+5bXj6VXMpZCPkr6YZWsB0Z_sTBxFxNpwa6D0Z0Q@mail.gmail.com>
2020-05-05 8:26 ` Markus Elfring
[not found] ` <CAMV6ehE9YRxakbP9ahXkiZEPut8E3qYsN0cxiLqCWasfvLAWFw@mail.gmail.com>
2020-05-05 20:17 ` Markus Elfring
[not found] ` <CAMV6ehFCcSZtqpxonfbp6i_v5zzmnLJ9Gncx=5Y36R35wqTtDw@mail.gmail.com>
2020-05-06 6:12 ` Markus Elfring
[not found] ` <CAK8KejrEuumVxdbBmuHbhjXQa7KH_jP-XLmAHjp1+AC7DUa9WQ@mail.gmail.com>
2020-05-07 7:23 ` [v3] nfp: abm: University research groups? Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=265a25f7-6ef1-1387-d60a-9ffe8ccfbd73@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=kjlu@umn.edu \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox