From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753236AbcA2KIE (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Jan 2016 05:08:04 -0500
Received: from mout.kundenserver.de ([217.72.192.73]:59476 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751699AbcA2KIB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Jan 2016 05:08:01 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Felipe Balbi <balbi@kernel.org>, Imre Kaloz <kaloz@openwrt.org>,
        Krzysztof Halasa <khalasa@piap.pl>,
        Russell King <linux@arm.linux.org.uk>, Daniel Mack <daniel@zonque.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>, Felipe Balbi <balbi@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch
Date: Fri, 29 Jan 2016 11:07:18 +0100
Message-ID: <2664702.bXd9nOWVFO@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <87vb6c7mug.fsf@belgarion.home>
References: <1453997722-3489596-1-git-send-email-arnd@arndb.de> <1453997843-3489728-1-git-send-email-arnd@arndb.de> <87vb6c7mug.fsf@belgarion.home>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:YlE1mW4mrGtrRdMMmZAtZKGZAm2UR/POSwygP/dwf5h6D4SpFQ2
 WILwZF/5IzaPXjM/zqfpGWGXysbH2EU3jK6TqJzgHz+VlnSahrABhyinr7PxBQ2kI+iyNjw
 5BwFMvvNa8ptXtoRauWMVbFKU+XNHc90c5xDFRIME54y0QGadRaMh5QggEMg9nSmDFxQ0nM
 T/UGklszJaMkL9N0pozJw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:awQULWuW5X0=:Ua5oU/tsBYou6N/ve9EPQo
 x4dHs/dRQsdN/9KJynqHQc6g87arSLizZY16gYvmS0fajz5A3wxMX3ucI0WpRfrw9PS+cvTQq
 UoLesQuy/JxbC5GJZZL95T1MfHfqYwNC3AKcmNI/w3anewI9wzsFHiMKNiPH6tpOOgr7sXA53
 KC0Vu40XEXihPDD8q5l7oRFNqvbXCgRu6rRhK7KWfxdgQOothYrH8wmlt/fyTbwn3fzhO3gaR
 7kzK4UoyHgb2tkSrGZjgT2PVXPK9VWc8Q98Q+T4NFqGpMWo+uVQ7oEgVs0DuoX7zWyLAvuygS
 tLui2gNpQxRZWZYZSUrplagM8UqhcIIvS6GfRMoB39xYKQuM44a8OarIBpTs0a5c5kVGjtkBA
 8GeZe2s4MA4V6TaqHKoNTwyLm6i4Ifxj0pelVtegRzzV6QkfYpXw6ZMHYrJn29yx/q35KpxaE
 BuoN/uYvAksfFvN3N/UszcK8jGXbxsbvvGEaQV0okHIeGTivLIJGyL85nYf2ygVk9R9WAC+RJ
 KDGSiOFMLqClAt0LkYsp77JRNaYdWqN/dra/dBaDDSbb8UH+JLSUi4e1w6PPpAQxrz09N7ioy
 +K/pjP2gavBPqM4NV85aUTzFs6TGPz3KPJPn4kmx3aU4/uqv6mvA2Fh9OY5MJe6rFze1+X1vA
 Kt00a/LjC1f2D55C9GATCUZzWPpVxVEjtfGmN91iVhkMgtGLkr5GQkakXiE4fkfYkb2jG9AGO
 VnXQcWOKNumtUkcN
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 29 January 2016 10:32:07 Robert Jarzmik wrote:
> > This addresses both issues by moving all the definitions into the
> > pxa25x_udc driver itself. It turns out the only difference between
> > them was 'UDCCS_IO_ROF', and that could well be a mistake when it
> > was incorrectly copied from pxa25x to ixp4xx.
> Hi Arnd,
> 
> Is there a reason to have chosen to move into pxa25_udc.c instead of
> drivers/usb/gadget/udc/pxa25x_udc.h ? pxa27x_udc has a .h in the same directory
> with register definitions, hence the question.

Yes: The register definitions are only used in a single .c file and
are not an interface between files, so it's better to have them in
the file that uses them.

I could have continued the cleanup and moved the two headers into the
respective drivers as well, but I had to stop somewhere ;-)

	Arnd