From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Josh Boyer <jwboyer@redhat.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
gregkh@linuxfoundation.org, mdharm-usb@one-eyed-alien.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: USB autosuspend vs. URB submission
Date: Thu, 10 Jan 2013 00:05:55 +0100 [thread overview]
Message-ID: <2664900.viczl5BYBS@avalon> (raw)
In-Reply-To: <20130108160321.GC12363@hansolo.jdub.homelinux.org>
Hi Josh,
On Tuesday 08 January 2013 11:03:22 Josh Boyer wrote:
> On Tue, Jan 08, 2013 at 10:51:20AM -0500, Alan Stern wrote:
> > On Mon, 7 Jan 2013, Josh Boyer wrote:
> > > Hi,
> > >
> > > We've had a few reports in Fedora of users hitting the WARN_ONCE in
> > > drivers/usb/core/urb.c that prints a warning about a usb_submit_urb
> > > being called on an active URB. One of them[1] is from the ums_realtek
> > > driver and the other[2] is from the uvcvideo driver. However, I noticed
> > > that in both instances it seems the devices were coming back from what I
> > > think is autosuspend.
> > >
> > > I didn't immediately find any similar reports, and to my rather
> > > inexperienced eyes the drivers didn't seem to be doing anything clearly
> > > wrong. I'm wondering if anyone has some possible ideas for debugging
> > > and whether or not this might be a general issue?
> >
> > I don't see anything wrong either.
> >
> > Can you ask the users to collect a usbmon trace covering the period
> > when the problem occurs?
>
> I'll certainly ask. I'm not particularly hopeful for great results though,
> as the problems seem to be rather intermittent.
>
> Thanks for taking a look.
I've never heard of such problems with the uvcvideo driver, and I don't see
anything wrong with the code at first sight. The driver only submits URBs when
starting the video capture (at that point no URB should be in flight) or in
the URB completion handler (by definition the URB has completed then).
I've had a quick look at the trace posted at
https://bugzilla.redhat.com/show_bug.cgi?id=879462 but usbmon only shows URBs
that are successfully submitted. I'm not sure what useful information I could
get from the trace.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-01-09 23:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 20:42 USB autosuspend vs. URB submission Josh Boyer
2013-01-08 15:51 ` Alan Stern
2013-01-08 16:03 ` Josh Boyer
2013-01-09 23:05 ` Laurent Pinchart [this message]
2013-01-10 5:13 ` Ming Lei
2013-01-10 10:02 ` Oliver Neukum
2013-01-10 9:42 ` Oliver Neukum
2013-01-10 15:20 ` Alan Stern
2013-01-10 15:37 ` Oliver Neukum
2013-01-10 15:13 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2664900.viczl5BYBS@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=gregkh@linuxfoundation.org \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox