From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932801AbeCSIvj (ORCPT ); Mon, 19 Mar 2018 04:51:39 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:48115 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754531AbeCSIvi (ORCPT ); Mon, 19 Mar 2018 04:51:38 -0400 Subject: Re: [RESEND PATCH v1 6/6] i2c: i2c-stm32f7: Implement I2C recovery mechanism To: Wolfram Sang CC: Maxime Coquelin , Alexandre Torgue , , , References: <1520852023-27083-1-git-send-email-pierre-yves.mordret@st.com> <1520852023-27083-7-git-send-email-pierre-yves.mordret@st.com> <20180317204720.mclh4jw5owobbtww@ninjato> From: Pierre Yves MORDRET Message-ID: <2672947b-46b2-7bd7-ac13-501db8bde72b@st.com> Date: Mon, 19 Mar 2018 09:51:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180317204720.mclh4jw5owobbtww@ninjato> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-19_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yes. Recovery mechanism is triggered whenever a busy line is detected. This busy state can be checked by sw when either SDA or SCL is low: a bit is set by Hw for this purpose. On busy state I2C is reconfigured and lines are released the time of recovery. Regards On 03/17/2018 09:47 PM, Wolfram Sang wrote: > On Mon, Mar 12, 2018 at 11:53:43AM +0100, Pierre-Yves MORDRET wrote: >> Feature prevents I2C lock-ups. Mechanism resets I2C state machine >> and releases SCL/SDA signals but preserves I2C registers. > > Does it release SDA when held down by the slave? Because that is what > the recovery mechanism is for. >