From: "Nicolai Hähnle" <nhaehnle@gmail.com>
To: Dave Airlie <airlied@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] drm for v4.15
Date: Fri, 17 Nov 2017 13:51:09 +0100 [thread overview]
Message-ID: <26729c32-cfd6-82e0-b370-a46ca951adea@gmail.com> (raw)
In-Reply-To: <CAPM=9txQo2yAe1nwUtyYETbGdgjY9GHgmXYYC=1ojyydUb72HQ@mail.gmail.com>
On 16.11.2017 21:57, Dave Airlie wrote:
> On 16 November 2017 at 14:59, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>> On Wed, Nov 15, 2017 at 6:34 PM, Dave Airlie <airlied@gmail.com> wrote:
>>>
>>> There is some code touched on sound/soc, but I think the sound tree
>>> should have the same commits from the same base,so this may luck different
>>> if you pulled it as I generated my pull request a couple of days ago. Otherwise
>>> the highlights are below.
>>
>> I'm more curious about (and disgusted by) this one:
>>
>> include/dt-bindings/msm/msm-bus-ids.h
>>
>> wtf? It's full of defines that aren't actually used anywhere. Which
>> is just as well, since it doesn't seem to be included from anything
>> either.
>>
>> There's something odd about drm people. You guys like these completely
>> insane generated header files, and you seem to be populating the whole
>> tree with this odd and diseased notion of "generated header files are
>> cool".
>>
>> Is somebody getting paid by line of code?
>
> It would still cost less than transcribing each register and all it's fields by
> hand from pdfs generated from the same place.
This raises the question of how people feel about putting the source
database into the kernel (most likely as XML in our case) and
auto-generating the headers from there instead.
I've been pondering doing this in Mesa for radeonsi for quite some time
now. Given that the Mesa header style is different from the kernel
header style, this could help reduce our IP review load going forward,
and would have some other neat benefits as well.
Cheers,
Nicolai
--
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.
next prev parent reply other threads:[~2017-11-17 12:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 2:34 [git pull] drm for v4.15 Dave Airlie
2017-11-16 4:59 ` Linus Torvalds
2017-11-16 13:57 ` Rob Clark
2017-11-16 17:17 ` Michel Dänzer
2017-11-16 20:57 ` Dave Airlie
2017-11-16 21:05 ` Linus Torvalds
2017-11-17 12:51 ` Nicolai Hähnle [this message]
2017-11-17 16:57 ` Linus Torvalds
2017-11-17 17:19 ` Lukas Wunner
2017-11-17 17:24 ` Linus Torvalds
2017-11-17 18:14 ` Christian König
2017-11-17 18:55 ` Linus Torvalds
2017-11-17 19:18 ` Christian König
2017-11-18 10:49 ` Nicolai Hähnle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26729c32-cfd6-82e0-b370-a46ca951adea@gmail.com \
--to=nhaehnle@gmail.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox