From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759040AbbBHXFg (ORCPT ); Sun, 8 Feb 2015 18:05:36 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:65506 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752254AbbBHXFe (ORCPT ); Sun, 8 Feb 2015 18:05:34 -0500 From: "Rafael J. Wysocki" To: Dan Carpenter , Quentin Lambert Cc: Pavel Machek , Joe Perches , Ming Lei , Greg Kroah-Hartman , Len Brown , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message Date: Mon, 09 Feb 2015 00:28:35 +0100 Message-ID: <2675935.6VkJO9HMpc@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150207102436.GB5206@mwanda> References: <20150206153912.GA8486@sloth> <20150206211708.GA25967@amd> <20150207102436.GB5206@mwanda> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, February 07, 2015 01:24:36 PM Dan Carpenter wrote: > Facts: > 1) None of these four error messages will ever be printed. > http://lwn.net/Articles/627419/ > 2) These messages are a waste of RAM. So this is what the changelog should be saying, not that it "fixes checkpatch warnings". checkpatch warnings in *existing* code are meaningless, unless they uncover a *real* problem in it which quite arguably this one is. But in those cases patch changelogs should talk about the *real* problems and they don't even need to mention checkpatch then as far as I'm concerned. Send this one with a better changelog and I'll apply it. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.