From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] V4L: v4l1-compat, fix VIDIOCSPICT for non-OVERLAY
Date: Tue, 8 May 2007 20:25:27 +0200 (CEST) [thread overview]
Message-ID: <26766101783271028925@wsc.cz> (raw)
In-Reply-To: <32177258712660011096@wsc.cz>
v4l1-compat, fix VIDIOCSPICT for non-OVERLAY
Do not return EINVAL for devices, which don't support overlay.
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
commit 637f1c324c57b002bcc94f68a1150e1ff32593c4
tree cf35d8f5990c1f335778bd85a4461c4e716daeef
parent fdc535e5e7c1b1781e903d4d21e1f657a9ac12c9
author Jiri Slaby <jirislaby@gmail.com> Sun, 06 May 2007 19:48:30 +0200
committer Jiri Slaby <jirislaby@gmail.com> Sun, 06 May 2007 19:48:30 +0200
drivers/media/video/v4l1-compat.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/v4l1-compat.c b/drivers/media/video/v4l1-compat.c
index a861e15..254df73 100644
--- a/drivers/media/video/v4l1-compat.c
+++ b/drivers/media/video/v4l1-compat.c
@@ -653,8 +653,8 @@ v4l_compat_translate_ioctl(struct inode *inode,
err = drv(inode, file, VIDIOC_S_FBUF, &fbuf2);
if (err < 0)
dprintk("VIDIOCSPICT / VIDIOC_S_FBUF: %d\n",err);
- err = 0; /* likely fails for non-root */
}
+ err = 0; /* G_ fails for non-OVERLAY, S_ likely for non-root */
break;
}
case VIDIOCGTUNER: /* get tuner information */
next prev parent reply other threads:[~2007-05-08 18:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 18:24 [PATCH 1/2] V4L: videodev, allow VIDIOCGMBUF Jiri Slaby
2007-05-08 18:25 ` Jiri Slaby [this message]
2007-05-08 21:20 ` [PATCH 2/2] V4L: v4l1-compat, fix VIDIOCSPICT for non-OVERLAY Mauro Carvalho Chehab
2007-05-08 21:15 ` [PATCH 1/2] V4L: videodev, allow VIDIOCGMBUF Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26766101783271028925@wsc.cz \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox