From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: Konstantin Kletschke <konsti@ludenkalle.de>,
linux-kernel@vger.kernel.org
Subject: Re: Quick aic7xxx bug hunt...
Date: Mon, 23 Sep 2002 16:44:58 -0600 [thread overview]
Message-ID: <2678680816.1032821098@aslan.btc.adaptec.com> (raw)
In-Reply-To: <3D8F934F.7000606@mandrakesoft.com>
> Great, I stand corrected. Looks like 2.5 code is ancient then?
Yes. I didn't do the original port and am now just finishing up my
port to 2.5.X.
> comments on the 2.4 code:
> * the 1000us delay in ahc_reset needs to be turned into a sleep, instead
> all paths to that function [AFAICS] can sleep. likewise for the huge
> delay in ahc_acquire_seeprom.
For all of these delays, I'd be more than happy to make them all into
sleeps if I can tell, from inside ahc_delay() if I'm in a context where
it is safe to sleep. On the other platforms that this core code runs on
I'm usually not in a context where it is safe to sleep, so I don't want
to switch to using a different driver primitive.
> * PCI posting? (aic7xxx_core.c, line 1322, the last statement in the
> function...)
>
> ahc_outb(ahc, CLRINT, CLRSCSIINT);
I don't care when the write occurs only that it will occur eventually.
The buffer will get flushed eventually so there is no need to call
ahc_flush_device_writes().
--
Justin
next prev parent reply other threads:[~2002-09-23 22:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-23 18:00 2.4.20-pre7-ac3 aic7xxx broken? Konstantin Kletschke
2002-09-23 19:15 ` Justin T. Gibbs
2002-09-23 21:27 ` Quick aic7xxx bug hunt Jeff Garzik
2002-09-23 21:54 ` Justin T. Gibbs
2002-09-23 22:18 ` Jeff Garzik
2002-09-23 22:44 ` Justin T. Gibbs [this message]
2002-09-23 22:50 ` Jeff Garzik
2002-09-23 22:55 ` Justin T. Gibbs
2002-09-23 23:22 ` Jeff Garzik
2002-09-23 23:28 ` Jeff Garzik
2002-09-23 7:44 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2678680816.1032821098@aslan.btc.adaptec.com \
--to=gibbs@scsiguy.com \
--cc=jgarzik@mandrakesoft.com \
--cc=konsti@ludenkalle.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox