From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753621Ab0CXI5B (ORCPT ); Wed, 24 Mar 2010 04:57:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6991 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948Ab0CXI47 (ORCPT ); Wed, 24 Mar 2010 04:56:59 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20100323144843.GA10431@redhat.com> References: <20100323144843.GA10431@redhat.com> To: Oleg Nesterov Cc: dhowells@redhat.com, Andrew Morton , Peter Zijlstra , Roland McGrath , linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm 2/2] keyctl_session_to_parent: use thread_group_empty() to check singlethreadness Date: Wed, 24 Mar 2010 08:56:41 +0000 Message-ID: <26794.1269421001@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oleg Nesterov wrote: > No functional changes. > > keyctl_session_to_parent() is the only user of signal->count which needs > the correct value. Change it to use thread_group_empty() instead, this > must be strictly equivalent under tasklist, and imho looks better. > > Signed-off-by: Oleg Nesterov Acked-by: David Howells