From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C6042DF13E; Fri, 19 Dec 2025 12:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766149058; cv=none; b=JDfINQDRtVsbQy9fr3kWq/s9Ugu+4oTDklSPMSMbtmpT9posDSYsUq2NEJwM7L5qPIXDUs+jSt7WR+8Kb5UX6/RrRG20Oo0qsSUQnV4Wg8em7Iul4lFQN9/NRaPQ043wOopP95sVgoeaSfCz+kOrHOkkZMopTlotQIPYsaeDb4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766149058; c=relaxed/simple; bh=5VTpuUf91XghjnpXnZ1PzWplcQyMMS94H9edLhZ9qxs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XzEGp78zKKVufJra1elvGYD+84QHSDe4Et91sIqEq4KDESJYLKzpgEPR8MzqqhauiNrBkVOdeNt+oOL3uZq2tkHCNrv9eXRZ8OaP8oOLjZJeuq/rNTratxpMQYTQEr1et6bSPiZjaYYzXEvzEGdVuf0hBi7GXvUQBNNY9Yq+vbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Dd65jRbl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dd65jRbl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2269FC4CEF1; Fri, 19 Dec 2025 12:57:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766149057; bh=5VTpuUf91XghjnpXnZ1PzWplcQyMMS94H9edLhZ9qxs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Dd65jRblB4ZcfNK+5IBkuREw4tSLLpZJaB8IQJKcbr53HDIf8qWU3HinBdqMKFfob 7g1XpSCLLnRka3+naSSeRhIbnEiafxYsQcsz3cZq0MJDxDZSd38tJcAiLuohvkNz8W Nv2JpSCLvjMpmyYGJcNIoDxfXkeyCGbMJ0YKXT2P6iOi/za/Q+jOMdJwV3Xo85gTy2 RAH7LZpBKhpirSMQHmUgkxzs6glbrbCuAweoV5QiqnbGmObtiMud8dbsSPufjZX6OZ yI+8B4YMfr9GTpB9EPVYO+IawlepdHDzFdQjuWSo5f2HjNVT/ZOrVBGxUNzuMQyHte mu4+MhefbJh5Q== Message-ID: <267dad52-0f22-4e5b-a929-a77cdc062490@kernel.org> Date: Fri, 19 Dec 2025 13:57:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: x1e78100-t14s: Add audio playback over DisplayPort To: Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Abel Vesa References: <20251217120051.98198-3-krzysztof.kozlowski@oss.qualcomm.com> <20251217120051.98198-4-krzysztof.kozlowski@oss.qualcomm.com> <2d4953c6-184d-423b-80e9-871c6e00da35@oss.qualcomm.com> <564732e7-2c86-417d-8568-69f40ea7d4da@kernel.org> <47758ce9-5ec6-4ed6-9f84-13cbdd444d75@oss.qualcomm.com> <487ff592-e67c-41c8-a398-f79aa6e5f69c@kernel.org> <455edd55-132d-423d-b0c0-afc7fa40aa30@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <455edd55-132d-423d-b0c0-afc7fa40aa30@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/12/2025 13:53, Konrad Dybcio wrote: > On 12/17/25 2:00 PM, Krzysztof Kozlowski wrote: >> On 17/12/2025 13:51, Konrad Dybcio wrote: >>> On 12/17/25 1:38 PM, Krzysztof Kozlowski wrote: >>>> On 17/12/2025 13:33, Konrad Dybcio wrote: >>>>> On 12/17/25 1:00 PM, Krzysztof Kozlowski wrote: >>>>>> Add necessary DAI links and DAI name prefixes to enable audio playback >>>>>> over USB/DisplayPort and HDMI. The HDMI port is not yet enabled, but it >>>>>> should carry respective DAI name prefix regardless. >>>>>> >>>>>> Reviewed-by: Abel Vesa >>>>>> Signed-off-by: Krzysztof Kozlowski >>>>>> >>>>>> --- >>>>> >>>>> (something's inserting a \n before --- in your latest patches but I >>>> >>>> No, it is not. It was always like that and only recently git started >>>> dropping it, but it is irrelevant. >>>> >>>>> don't know if this is a problem) >>>>> >>>>> [...] >>>>> >>>>>> + displayport-2-dai-link { >>>>>> + link-name = "DisplayPort2 Playback"; >>>>>> + >>>>>> + codec { >>>>>> + sound-dai = <&mdss_dp2>; >>>>> >>>>> How does this work out with fw_devlink? >>>> >>>> How is this related to this patchset? Please stop nit-picking irrelevant >>>> things. >>> >>> I'm asking whether this is going to break sync_state because you're not >>> enabling mdss_dp2 - I believe that's a fair question.. >> >> DTS description is independent of driver, thus this is correct code >> regardless whether there is interconnect involved anywhere or not. I >> don't have the answer how this affects interconnect, but I see no reason >> anyone would create such ICC path - between hardware and fake SW construct. > > sync_state isn't exclusive to the interconnect framework > > In any case, could you please confirm/deny that sound still works as > expected with linux-next/master + this patch alone and we move on? It was working all the time - I was using it on my machine for 3 months already. Other people are also using it, because it is part of our laptop tree and no regressions or issues were reported. Best regards, Krzysztof