public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx93: add wdog3 node
@ 2023-05-05  9:31 Peng Fan (OSS)
  2023-05-08  6:34 ` Alexander Stein
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Fan (OSS) @ 2023-05-05  9:31 UTC (permalink / raw)
  To: shawnguo, s.hauer
  Cc: kernel, festevam, linux-imx, linux-kernel, linux-arm-kernel,
	Peng Fan

From: Peng Fan <peng.fan@nxp.com>

Add wdog3 node, then watchdog could be used.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx93.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index e8d49660ac85..73ecd953ec8d 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -344,6 +344,14 @@ mu2: mailbox@42440000 {
 				status = "disabled";
 			};
 
+			wdog3: wdog@42490000 {
+				compatible = "fsl,imx93-wdt";
+				reg = <0x42490000 0x10000>;
+				interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX93_CLK_WDOG3_GATE>;
+				timeout-sec = <40>;
+			};
+
 			tpm3: pwm@424e0000 {
 				compatible = "fsl,imx7ulp-pwm";
 				reg = <0x424e0000 0x1000>;
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: imx93: add wdog3 node
  2023-05-05  9:31 [PATCH] arm64: dts: imx93: add wdog3 node Peng Fan (OSS)
@ 2023-05-08  6:34 ` Alexander Stein
  0 siblings, 0 replies; 2+ messages in thread
From: Alexander Stein @ 2023-05-08  6:34 UTC (permalink / raw)
  To: shawnguo, s.hauer, linux-arm-kernel
  Cc: kernel, festevam, linux-imx, linux-kernel, linux-arm-kernel,
	Peng Fan, Peng Fan (OSS)

Hello,

thanks for the patch.

Am Freitag, 5. Mai 2023, 11:31:30 CEST schrieb Peng Fan (OSS):
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add wdog3 node, then watchdog could be used.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi index e8d49660ac85..73ecd953ec8d
> 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -344,6 +344,14 @@ mu2: mailbox@42440000 {
>  				status = "disabled";
>  			};
> 
> +			wdog3: wdog@42490000 {

I think this should be called 'watchdog@42490000'

> +				compatible = "fsl,imx93-wdt";
> +				reg = <0x42490000 0x10000>;
> +				interrupts = <GIC_SPI 79 
IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clk IMX93_CLK_WDOG3_GATE>;
> +				timeout-sec = <40>;

Should it be disabled it by default?

> +			};
> +
>  			tpm3: pwm@424e0000 {
>  				compatible = "fsl,imx7ulp-pwm";
>  				reg = <0x424e0000 0x1000>;

Is there a reason you just add watchdog3? There are 5 in total.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-08  6:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-05  9:31 [PATCH] arm64: dts: imx93: add wdog3 node Peng Fan (OSS)
2023-05-08  6:34 ` Alexander Stein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox