From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751325AbcBLTt5 (ORCPT ); Fri, 12 Feb 2016 14:49:57 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:60516 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbcBLTtz (ORCPT ); Fri, 12 Feb 2016 14:49:55 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Stephen Boyd , Mark Brown , linux-arm-msm@vger.kernel.org, Kenneth Westfield , Kevin Hilman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "ASoC: qcom: Specify LE device endianness" Date: Fri, 12 Feb 2016 20:48:58 +0100 Message-ID: <2686474.cvCA6vY47l@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1455298217-15744-1-git-send-email-sboyd@codeaurora.org> References: <1455298217-15744-1-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:m5m2VUOH6zlGNIrywn/uPJMQ4PWqz4tACCr7VhwGhUU1YONFob6 Wt8f75RDhIlDDNra0taDb9ho6mdOuO1imLYvZgoo2UevUNmqlno5EXWzN8gDCMdjvZikNp8 BtNBhJDl/XrhRwpzxr8sUAGTv2Kbqq0N0FZvPGBD1G9uR3Ya1Rv2l4rQFE5s7kOuR6sNha0 PuoOARqg+OipzY+0BP95w== X-UI-Out-Filterresults: notjunk:1;V01:K0:gEvdv4YmjOk=:Ois6GhTsCTo0Co1DeAL/S5 4Z3VR+F8nzUb9SGuSISWzV//GpLwHs4WF9nTdvb+7/ljNVqvaZBF1POTwm9m0IoroM2lNj2I2 tw1U9WNFeXWJnuKjycsNCHFoqkcCqcprcIslJILHqoGrnR5hHdW4K2IIf56bmrI+6tjmBFIAD jXPTpwICX9tqUFeCTptGqZB5r92tIz2ZZDzkNOF8hYJQrBPIU7l9chuMeEAY26Ll2H7eDDC7L 7MJyEWoess4Zosw5QUfzJbilEy289/Zui7i2eSRRoKtu9e0Ii57dv0bG64KQcI1+YZS2++I1J YS5+EjozskJ09RP1COY2Bomp0o+D9vidv056SMUlDZ4PBAnohiWSLNEM5ovMiPWGHUcVUn8BG 6fcveZLSuN/CVewlUqMduKpVOYCW95q/ov+CS9UVMqqqWC4tfTSar7hjOo+rlK5TomxF3a3mR vyLg+ivfgGn3c08H29AfADJm9fOkv/VFd8LU8V+tQgMqS9kjV3Gu/jk3tvDUJWQJaKnynbT5h 3uXM5lbcdbzB9fzOJ7qdeMTI7wlSc7QtG/4w56dnIl9g2lPTTXNHpKhwXCdiMhUo47z88XPoW NiQOC7pKyqrwqbtRV0TOKsjg73IhZTmBRidT6WuKDtxMmQH/yqwHLdxxOGWYXnjq5BRR60hwz UExHl/2y82v8nOr/qOea6DdJZVGDFXfZN1muZcpUQqAGb20y3fIzEdXvYrwfFv0VpeBIXWUcj vKoJYvXarWabFlKP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 12 February 2016 09:30:17 Stephen Boyd wrote: > This reverts commit 18560a4e3b07438113b50589e78532d95f907029. > > The commit that caused us to specify LE device endianness here, > 29bb45f25ff3 (regmap-mmio: Use native endianness for read/write, > 2015-10-29), has been reverted in mainline so now when we specify > LE it actively breaks big endian kernels because the byte > swapping in regmap-mmio is incorrect. Let's revert this change > because it will 1) fix the big endian kernels and 2) be redundant > to specify LE because that will become the default soon. > > Cc: Kenneth Westfield > Cc: Kevin Hilman > Signed-off-by: Stephen Boyd Ah, too bad to have to revert a correct change until the infrastructure is fixed properly, but I guess it's the easier way out here. What about the other uses of REGMAP_ENDIAN_LITTLE in the kernel? In particular I see drivers/clk/nxp/clk-lpc32xx.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/gcc-apq8084.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/gcc-ipq806x.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/gcc-msm8660.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/gcc-msm8916.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/gcc-msm8960.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/gcc-msm8960.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/gcc-msm8974.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/lcc-ipq806x.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/lcc-msm8960.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/mmcc-apq8084.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/mmcc-msm8960.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/mmcc-msm8960.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/clk/qcom/mmcc-msm8974.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, drivers/nvmem/qfprom.c: .val_format_endian = REGMAP_ENDIAN_LITTLE, and of course drivers/mfd/syscon.c: syscon_config.val_format_endian = REGMAP_ENDIAN_LITTLE; which all look like they are regmap_mmio users as well. Do they suffer from the same problem? Arnd