From: David Howells <dhowells@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
Marc Dionne <marc.dionne@auristor.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
"Junvyyang, Tencent Zhuque Lab" <zhuque@tencent.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net 2/2] rxrpc: Fix bug due to prealloc collision
Date: Tue, 08 Jul 2025 20:57:30 +0100 [thread overview]
Message-ID: <2687076.1752004650@warthog.procyon.org.uk> (raw)
In-Reply-To: <20250708120336.03383758@kernel.org>
Jakub Kicinski <kuba@kernel.org> wrote:
> On Mon, 7 Jul 2025 11:24:34 +0100 David Howells wrote:
> > + rxrpc_prefail_call(call, RXRPC_CALL_LOCAL_ERROR, -EBADSLT);
> > + __set_bit(RXRPC_CALL_RELEASED, &call->flags);
>
> is the __set_bit() needed / intentional here?
> Looks like rxrpc_prefail_call() does:
>
> WARN_ON_ONCE(__test_and_set_bit(RXRPC_CALL_RELEASED, &call->flags));
Actually, it shouldn't be. I added that first, then realised that wasn't
sufficient.
I also realised there should be a third patch I failed to restack onto the git
branch.
Can you take the first patch and I'll alter this and repost this patch and add
the lost one? Or should I just repost all three?
David
next prev parent reply other threads:[~2025-07-08 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 10:24 [PATCH net 0/2] rxrpc: Miscellaneous fixes David Howells
2025-07-07 10:24 ` [PATCH net 1/2] rxrpc: Fix over large frame size warning David Howells
2025-07-07 10:24 ` [PATCH net 2/2] rxrpc: Fix bug due to prealloc collision David Howells
2025-07-08 19:03 ` Jakub Kicinski
2025-07-08 19:57 ` David Howells [this message]
2025-07-08 20:20 ` [PATCH net 0/2] rxrpc: Miscellaneous fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2687076.1752004650@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhuque@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox