public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* usb: gadget: net2280: CONFIG_USB_GADGET_PDEBUG_FILES?
@ 2014-07-04  7:37 Paul Bolle
  2014-07-04  9:27 ` Ricardo Ribalda Delgado
  2014-07-05 14:55 ` [USB spamming log] with 3.16-rc (git) my pl2303 is spaming my logs Ed Tomlinson
  0 siblings, 2 replies; 5+ messages in thread
From: Paul Bolle @ 2014-07-04  7:37 UTC (permalink / raw)
  To: Ricardo Ribalda Delgado, Felipe Balbi, Greg Kroah-Hartman
  Cc: linux-usb, linux-kernel

Commit e56e69cc0ff4 ("usb: gadget: net2280: Use pr_* function") is
included in today's linux-next (ie, next-20140704).

It contains this odd chunk:
    @@ -1566,7 +1563,7 @@ static const struct usb_gadget_ops net2280_ops = {
     
     /*-------------------------------------------------------------------------*/
     
    -#ifdef CONFIG_USB_GADGET_DEBUG_FILES
    +#ifdef CONFIG_USB_GADGET_PDEBUG_FILES
     
     /* FIXME move these into procfs, and use seq_file.
      * Sysfs _still_ doesn't behave for arbitrarily sized files,

(Commit b7ca96655ddd ("usb: gadget: Gadget directory cleanup - group UDC
drivers"), also included in today's linux-next, moved that new check for
CONFIG_USB_GADGET_PDEBUG_FILES to drivers/usb/gadget/udc/net2280.c.)

Using CONFIG_USB_GADGET_PDEBUG_FILES appears to be just an editing
mistake. Would Ricardo like to submit the trivial patch to clean it up
or should I do that?


Paul Bolle


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-07-06  1:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-04  7:37 usb: gadget: net2280: CONFIG_USB_GADGET_PDEBUG_FILES? Paul Bolle
2014-07-04  9:27 ` Ricardo Ribalda Delgado
2014-07-05 14:55 ` [USB spamming log] with 3.16-rc (git) my pl2303 is spaming my logs Ed Tomlinson
2014-07-05 18:02   ` Greg KH
2014-07-06  1:42     ` Ed Tomlinson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox