From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EC96165F13 for ; Thu, 14 Aug 2025 14:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755181566; cv=none; b=MamTopSLKQpcVob955KGxYFJQo4eK4pItIvfR83IMf4Q2dd0jqRXA9/PjKZH1E6aUU9t3sRCQWI04uEXId0ozeMZn2Dq4G8Y8xeEmDibpg4uep9ExOipmSE6si54FDcXXg8POoJ380wsnoVBhjZCZ2MbTAC6uEXB5+YsyrwwFlA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755181566; c=relaxed/simple; bh=gBxFOxvGALu7sDdFgybOnYEKn/o04vIZg4lyyrzwuEg=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=geVuZrdrCG4nLYPCjaD8YUonTsBLckTqYSBRyGk17n9Osi/RmylpC/LslFfJBKh+AgP/5DEAv43jYVIurpu8LOJE5GI4eejxhjOwiOeRPPKIPmeEjqUh+8WYkmZsVgsaxG7Ye8d7xi6qxm1vdZG5sccvbvzzZJyqGR5JfBdFdPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DlAmHPM3; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DlAmHPM3" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-45a1b0990b2so6757825e9.2 for ; Thu, 14 Aug 2025 07:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755181562; x=1755786362; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=cUV3fUJR8K/LNtQMHHFa+NVRtvkhhAA1yMnYl/5MEqg=; b=DlAmHPM3v4Q7MdPk5x1gzGr8YS8hyzVRNWcy7yrqkdEzkPjv1ugpyvAuMFlY5nQbUo qe0S8qgaDsC0KptuqgFDpxrLk0JNsx58aQYePwTFF4qmlYaQ+7qMQezLHtA+T/sedbTR Vdqgb4jvxp2b1OlkeNS7KRYce22Ezip3veJuAH2FfwzJBB0bWZQHqwAgt5fy6vATL+PK WGpPqlN65ZTbl3oCV3f5YDWNs633CnIqRsoNeHluhCeUxgl1CwMtcLo9Em4tbADVMkA8 yoH/Uy41qFbzWuSjo4PO9k/PqjCbsqL7uOoV1UoDESPRP1XROO9dCFySVxmgrBzO35sJ GUwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755181562; x=1755786362; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=cUV3fUJR8K/LNtQMHHFa+NVRtvkhhAA1yMnYl/5MEqg=; b=luxRahIMIh8Tr8yNTVLSJ3fQx36UZTo9CBIrO98RWbKNM5Kr2hp1gajzy3vTOE7E1W aZdRQaBjGd3NshJBqKZvQOrFi/t04M+2S2NWhL7bdhTT/kkIFBwemnxGrzECynU9spgi 0e4+DIjSOuWQqpUkFqZTvB3Zhd6yqDkbFrVpnVMCtkzLZ2pcQdh0frwQttmlf9hE/qKH hjV7EK5qbsK5mZ2MOiJpGvglvYvLPnljLyJZFF4qrmC9KzYCs4AoxBkVfi2DqeW21r80 6g0anPEiMiLSYSG1eqcgtncy92bvDOICwlDIW2Qh0Fi7GrMN3E5/olPiwE7P23itNUcl NGpQ== X-Forwarded-Encrypted: i=1; AJvYcCWr0YZjiJt68XRd6pba1qXHwOH2mWhVHXveSrXt2TuHOnAb1+4KUv9Ad5dOTfAuKNCmIYWdpCKvAg/4Yyg=@vger.kernel.org X-Gm-Message-State: AOJu0YxW56lDDIH2jJLtpPKm0XTMj2xeR1USsUDqQ5tFyHG5nd9qNYYb YLv3gd9gyUpl9Ggn69zFVe5H1dkdugj9jLDYfN+ACzBYjCB+TgG52f1EwRhfCdcp2zw= X-Gm-Gg: ASbGncsFOQz65RrthgYnsQ56/Gx0aTpXX4zqJkIk458Hv2Opsi+xoHvsUY9DyFMDWRD hlmxZtuf73OgeptHKXACmZVoK9X3EskhmA5KtRipLxdKaPqN+b2xbrQ86Lc9KEEqRyVFUoc7jhx wew5yzG2WjeUHUIzfBqoHlce1enVScZ95KQw3Ex4KzQOK1RH/a/aaruvEt225+O+5LFAfVd1H0S vSU/QdXgNGYdDZU6t0QkesK2G21HcVy3AP4KEWl43mnPJMLJ88OcyrIMjg/lNrlycL2hsfW0hGz pwVq6wdAiQeXK6OjEVNGlCm44DhN5Tzx2QSH596/La+Yd7LVyuo2pULdO9TZxt9gyLQKG1tqxcE BBLp1V3KUKxM0oC8ysdx7ZzHbqWY7SljjJm/af+AEuKMQ66a/wN8W923JVycAB1oAZ3KnWi8T X-Google-Smtp-Source: AGHT+IH26+hLzQJtX2ss5voCJMw3O/X67D5ManbVwKM2eqgig1E2QKvsougttThvAf89+ZGPYwzR0Q== X-Received: by 2002:a05:600c:4587:b0:456:302:6dc3 with SMTP id 5b1f17b1804b1-45a1b65585bmr25542325e9.26.1755181562146; Thu, 14 Aug 2025 07:26:02 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:7336:e60:7f9e:21e6? ([2a01:e0a:3d9:2080:7336:e60:7f9e:21e6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b91b05b28fsm4802655f8f.21.2025.08.14.07.26.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Aug 2025 07:26:01 -0700 (PDT) Message-ID: <269506b6-f51b-45cc-b7cc-7ad0e5ceea47@linaro.org> Date: Thu, 14 Aug 2025 16:26:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2] drm/msm: adreno: a6xx: enable GMU bandwidth voting for x1e80100 GPU To: Konrad Dybcio , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20250725-topic-x1e80100-gpu-bwvote-v2-1-58d2fbb6a127@linaro.org> <33442cc4-a205-46a8-a2b8-5c85c236c8d4@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 14/08/2025 13:22, Konrad Dybcio wrote: > On 8/14/25 1:21 PM, Konrad Dybcio wrote: >> On 7/31/25 12:19 PM, Konrad Dybcio wrote: >>> On 7/25/25 10:35 AM, Neil Armstrong wrote: >>>> The Adreno GPU Management Unit (GMU) can also scale DDR Bandwidth along >>>> the Frequency and Power Domain level, but by default we leave the >>>> OPP core scale the interconnect ddr path. >>>> >>>> Declare the Bus Control Modules (BCMs) and the corresponding parameters >>>> in the GPU info struct to allow the GMU to vote for the bandwidth. >>>> >>>> Reviewed-by: Dmitry Baryshkov >>>> Signed-off-by: Neil Armstrong >>>> --- >>>> Changes in v2: >>>> - Used proper ACV perfmode bit/freq >>>> - Link to v1: https://lore.kernel.org/r/20250721-topic-x1e80100-gpu-bwvote-v1-1-946619b0f73a@linaro.org >>>> --- >>>> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 11 +++++++++++ >>>> 1 file changed, 11 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>>> index 00e1afd46b81546eec03e22cda9e9a604f6f3b60..892f98b1f2ae582268adebd758437ff60456cdd5 100644 >>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>>> @@ -1440,6 +1440,17 @@ static const struct adreno_info a7xx_gpus[] = { >>>> .pwrup_reglist = &a7xx_pwrup_reglist, >>>> .gmu_chipid = 0x7050001, >>>> .gmu_cgc_mode = 0x00020202, >>>> + .bcms = (const struct a6xx_bcm[]) { >>>> + { .name = "SH0", .buswidth = 16 }, >>>> + { .name = "MC0", .buswidth = 4 }, >>>> + { >>>> + .name = "ACV", >>>> + .fixed = true, >>>> + .perfmode = BIT(3), >>>> + .perfmode_bw = 16500000, >>> >>> Reviewed-by: Konrad Dybcio >> >> Actually no, BIT(3) is for the CPU (OS), GPU should use BIT(2) > > This is *very* platform-dependent, goes without saying.. > > I see BIT(2) is also valid for X1P4 I'm confused, Akhil can you confirm ? Neil > > Konrad