From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932299AbcBPPIf (ORCPT ); Tue, 16 Feb 2016 10:08:35 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:56375 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755132AbcBPPIe (ORCPT ); Tue, 16 Feb 2016 10:08:34 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Stefano Stabellini , linux-fbdev@vger.kernel.org, xen-devel@lists.xensource.com, Konrad Rzeszutek Wilk , Andrew Jones , linux-kernel@vger.kernel.org, Tomi Valkeinen , David Vrabel , boris.ostrovsky@oracle.com, Jean-Christophe Plagniol-Villard Subject: Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Date: Tue, 16 Feb 2016 16:05:20 +0100 Message-ID: <2697712.W9djLKoMG1@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1455278707-2008263-1-git-send-email-arnd@arndb.de> <2801550.oZPkqjv8nW@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:r3JJM4Fbi7R1CgGeJlGDVCw+zs9yy0tBBTTH8eVrl1PRSYZCxLS yP4ImH0l0O2ku8qAf4Qp1CAhkkbrqUOmtKat1evJ1Bigrl+/VDfV5uVhBrhXl5s3Qzfwpau PLb5rIUFND2P/R4AlboIFiyLs6Y5aUeF2pyyJIKHjromMOrBEoX5emgbbq6nitevYbMBiOF zX+Zm2hIGWd/1BF2vaQAQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:lk3MlWJQtfY=:JK8AvglCYmgqqnlC8D8vey vyLxkUY0NQLEMreQDWIiEFNxDohf7W/2JdbOwqYJrXl7WbRDp6L7pq35W6rMidvGHJzPfAZEe 9pXJxCTnCUZ+UwWA0CmjKXAy2k7PDykjyJuwGTZ+JTc8nSRg783CAwr6RiYU0BQ1HZGNuuYJ0 voJPLBFY/oZ07MFmo5g4lYOG0ZCXkLHf/5Utg97feg1TiORO3Wr8Lk1UXvn0iDc+UVsntZORR zLBLiTTg5Pr9r8u8iLijr4h/4eVsCXO86Kx8DQdecD5BQztY3XQVy31YaOWvuHHRdAMRHwM6A 9ZIHKQFimFT49QdTwPR0uqAhX32vYo3a0Y/KN+rvenLOJwmsI7/KYuiiwURrLr5OTqXluYjdw G0kYo6LhNoL0fMGQPkwI7dBqvozxt+12rFNJGLkpeM3Bp22VfWHECnbfNKWOwomW40tkPFmuL hmJt/yHQKSoVQ14gIZGCK7IzyOOUdzxR1Ixy9RtWCiAzfTqGTI/pCq1Y2eHx3AKWwuRHbjNPO QVL2MJ3WL/zTchReouhnfhjKTyCWOJdG5SsphLrpPGVeoa/0W6m9pq90qBKFWJTCXugIu5lTA Xg1YO8PhMcqGxufvPISiDiALbhcba9Mq63u4zMDRtgdj0+yhVEdfg1SXoO4ZDXLPtIeUFPDg8 93O056LgA9nWluxj2HEs+Of8bj8fLKmiWfwpHtfJF21vPk6Eux0pc1F+Yr7e9oOCUOjgshfgq N7YyhJPiCBQWUDSX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 16 February 2016 12:14:14 Stefano Stabellini wrote: > > at all. > > Please correct me if I am wrong, but the difference is that with this > change if INPUT=m, then the build system would ask the user whether she > wants to select INPUT_XEN_KBDDEV_FRONTEND as m or y, instead of > unconditionally set INPUT_XEN_KBDDEV_FRONTEND=y. INPUT_XEN_KBDDEV_FRONTEND cannot be set by the user to 'y' if INPUT=m, because of an implied dependency around the input/misc/Kconfig file. > However it is true that if the users chooses > INPUT_XEN_KBDDEV_FRONTEND=y, then the problem persists. > Maybe we also need: > > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig > index 1f2337a..303df24 100644 > --- a/drivers/input/misc/Kconfig > +++ b/drivers/input/misc/Kconfig > @@ -721,7 +721,7 @@ config INPUT_CMA3000_I2C > > config INPUT_XEN_KBDDEV_FRONTEND > tristate "Xen virtual keyboard and mouse support" > - depends on XEN > + depends on XEN && INPUT > default y > select XEN_XENBUS_FRONTEND > help > > > Do you have a kernel config with INPUT=m that I can use to test with? You can easily set that in any config if you disable CONFIG_VT. I don't think it's worth spending more time on that, as everyone seems to be happy with just removing the 'select', and I've sent a replacement patch to do that. Arnd