From: Konrad Dybcio <konradybcio@gmail.com>
To: Katherine Perez <kaperez@linux.microsoft.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH v3 1/1] arm64: dts: add minimal DTS for Microsoft Surface Duo 2
Date: Thu, 9 Dec 2021 17:03:50 +0100 [thread overview]
Message-ID: <2697db33-753c-ead8-019f-5e2ef1773693@gmail.com> (raw)
In-Reply-To: <20211208235137.2751003-2-kaperez@linux.microsoft.com>
Hi!
On 09/12/2021 00:51, Katherine Perez wrote:
> This is a minimal devicetree for Microsoft Surface Duo 2 with SM8350
> Chipset
>
> Signed-off-by: Katherine Perez <kaperez@linux.microsoft.com>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
> ---
>
> Changes since v1:
> - Change remoteprocs firmware-naming scheme to qcom/sm8350/microsft/*
> - Add chassis-type
>
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../qcom/sm8350-microsoft-surface-duo2.dts | 369 ++++++++++++++++++
> 2 files changed, 370 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
>
> --
> 2.31.1
[...]
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
> @@ -0,0 +1,369 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (C) 2021, Microsoft Corporation
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
This is now included in sm8350.dtsi
[...]
> +&usb_1 {
> + dr_mode = "peripheral";
> +};
> +
Looks like you forgot to enable usb_1, but other than these two nits:
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
prev parent reply other threads:[~2021-12-09 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 23:51 [PATCH v3 0/1] arm64: dts: sm8350: add support for Microsoft Surface Duo 2 Katherine Perez
2021-12-08 23:51 ` [PATCH v3 1/1] arm64: dts: add minimal DTS " Katherine Perez
2021-12-09 5:38 ` Vinod Koul
2021-12-09 16:03 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2697db33-753c-ead8-019f-5e2ef1773693@gmail.com \
--to=konradybcio@gmail.com \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kaperez@linux.microsoft.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox