From: Christian Schoenebeck <linux_oss@crudebyte.com>
To: Sasha Levin <sashal@kernel.org>, asmadeus@codewreck.org
Cc: ericvh@kernel.org, lucho@ionkov.net, v9fs@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 9p: Use hashtable.h for hash_errmap
Date: Sun, 23 Mar 2025 14:05:21 +0100 [thread overview]
Message-ID: <2699178.Jt51f5JuzZ@silver> (raw)
In-Reply-To: <Z98q_K71xueitBeB@codewreck.org>
On Saturday, March 22, 2025 10:26:20 PM CET asmadeus@codewreck.org wrote:
> Sasha Levin wrote on Thu, Mar 20, 2025 at 10:52:00AM -0400:
> > Convert hash_errmap in error.c to use the generic hashtable
> > implementation from hashtable.h instead of the manual hlist_head array
> > implementation.
> >
> > This simplifies the code and makes it more maintainable by using the
> > standard hashtable API and removes the need for manual hash table
> > management.
>
> I'm not entierly convinced this is simpler from my little island (that's
> one more API to learn about vs code that doesn't look all that
> different), but I guess I can see the point from an overall perspective.
>
> I see no problem with this, I'll pick it up for -next
> Note this code is not used for 9p2000l iirc so I currently don't have
> any test for it :/
> (but it's simple enough that I'm willing to take the risk)
Correct, that code is only used for legacy 9p2000 and 9p2000.u protocol
versions, but not for the default 9p2000.L version which is transmitting
numeric (Linux) error codes only (i.e. error strings are never transmitted
with 9p2000.L, hence no translation via hash map needed).
/Christian
prev parent reply other threads:[~2025-03-23 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 14:52 [PATCH] 9p: Use hashtable.h for hash_errmap Sasha Levin
2025-03-22 21:26 ` asmadeus
2025-03-23 13:05 ` Christian Schoenebeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2699178.Jt51f5JuzZ@silver \
--to=linux_oss@crudebyte.com \
--cc=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=sashal@kernel.org \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox