Re: [Update][PATCH] PCI / PM: Disable runtime PM of PCIe ports

Rafael J. Wysocki
2013-04-01T20:43:36Z

On Monday, April 01, 2013 11:34:46 AM Bjorn Helgaas wrote:
> [+cc Zheng, who added this with 71a83bd727]
>
> On Sat, Mar 30, 2013 at 4:38 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > The runtime PM of PCIe ports turns out to be quite fragile, as in
> > some cases things work while in some other cases they don't and we
> > don't seem to have a good way to determine whether or not they are
> > going to work in advance.
>
> Do you have any references to problems encountered when enabling
> runtime PM for PCIe ports? That information will be useful to anybody
> who wants to take another crack at getting this working.

Well, bug 53811 is one example and problems recently reported by
Martin are another. Do you want me to dig deeper?

Rafael

> > For this reason, avoid enabling runtime PM for PCIe ports by
> > keeping their runtime PM reference counters always above 0 for the
> > time being.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > ---
> >
> > This version also removes the no longer necessary (and empty anyway)
> > port_runtime_pm_black_list[] table.
> >
> > Thanks,
> > Rafael
> >
> > ---
> > drivers/pci/pcie/portdrv_pci.c | 13 -------------
> > 1 file changed, 13 deletions(-)
> >
> > Index: linux-pm/drivers/pci/pcie/portdrv_pci.c
> > ===================================================================
> > --- linux-pm.orig/drivers/pci/pcie/portdrv_pci.c
> > +++ linux-pm/drivers/pci/pcie/portdrv_pci.c
> > @@ -185,14 +185,6 @@ static const struct dev_pm_ops pcie_port
> > #endif /* !PM */
> >
> > /*
> > - * PCIe port runtime suspend is broken for some chipsets, so use a
> > - * black list to disable runtime PM for these chipsets.
> > - */
> > -static const struct pci_device_id port_runtime_pm_black_list[] = {
> > - { /* end: all zeroes */ }
> > -};
> > -
> > -/*
> > * pcie_portdrv_probe - Probe PCI-Express port devices
> > * @dev: PCI-Express port device being probed
> > *
> > @@ -225,16 +217,11 @@ static int pcie_portdrv_probe(struct pci
> > * it by default.
> > */
> > dev->d3cold_allowed = false;
> > - if (!pci_match_id(port_runtime_pm_black_list, dev))
> > - pm_runtime_put_noidle(&dev->dev);
> > -
> > return 0;
> > }
> >
> > static void pcie_portdrv_remove(struct pci_dev *dev)
> > {
> > - if (!pci_match_id(port_runtime_pm_black_list, dev))
> > - pm_runtime_get_noresume(&dev->dev);
> > pcie_port_device_remove(dev);
> > pci_disable_device(dev);
> > }
> >
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.