From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Pedro Falcato <pfalcato@suse.de>
Cc: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Jeff Xu <jeffxu@chromium.org>
Subject: Re: [PATCH 2/5] mm/mseal: move madvise() logic to mm/madvise.c
Date: Mon, 14 Jul 2025 16:37:33 +0100 [thread overview]
Message-ID: <26a1fc6d-d0c5-4f5c-9669-0593a9a6b59c@lucifer.local> (raw)
In-Reply-To: <nnm4cmygbeyzwxfwqduo5lq3d5cthuic5irof2l3tb5x43n2hz@mmjklktcfk2o>
On Mon, Jul 14, 2025 at 04:31:59PM +0100, Pedro Falcato wrote:
> On Mon, Jul 14, 2025 at 05:03:03PM +0200, David Hildenbrand wrote:
> > [...]
> >
> > But now I wonder, why is it okay to discard anon pages in a MAP_PRIVATE file
> > mapping?
>
> IIRC this was originally suggested by Linus, on one of the versions introducing
> mseal. But the gist is that discarding pages is okay if you could already zero
> them manually, using e.g memset. Hence the writeability checks.
Right, and if it's read-only and MAP_PRIVATE it doesn't really matter. In which
case we needn't worry.
I wonder if we need to check for VM_MAYWRITE though...
>
> --
> Pedro
next prev parent reply other threads:[~2025-07-14 15:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 13:00 [PATCH 0/5] mseal cleanups Lorenzo Stoakes
2025-07-14 13:00 ` [PATCH 1/5] mm/mseal: always define VM_SEALED Lorenzo Stoakes
2025-07-14 14:31 ` David Hildenbrand
2025-07-14 15:20 ` Pedro Falcato
2025-07-14 15:32 ` Liam R. Howlett
2025-07-14 13:00 ` [PATCH 2/5] mm/mseal: move madvise() logic to mm/madvise.c Lorenzo Stoakes
2025-07-14 14:37 ` David Hildenbrand
2025-07-14 14:56 ` Lorenzo Stoakes
2025-07-14 15:03 ` David Hildenbrand
2025-07-14 15:18 ` Lorenzo Stoakes
2025-07-14 15:24 ` David Hildenbrand
2025-07-14 15:27 ` Lorenzo Stoakes
2025-07-14 15:37 ` David Hildenbrand
2025-07-14 15:31 ` Pedro Falcato
2025-07-14 15:37 ` Lorenzo Stoakes [this message]
2025-07-14 15:41 ` David Hildenbrand
2025-07-14 15:45 ` Lorenzo Stoakes
2025-07-14 15:52 ` David Hildenbrand
2025-07-14 16:01 ` Lorenzo Stoakes
2025-07-14 15:18 ` Pedro Falcato
2025-07-14 15:33 ` Liam R. Howlett
2025-07-14 13:00 ` [PATCH 3/5] mm/mseal: small cleanups Lorenzo Stoakes
2025-07-14 14:39 ` David Hildenbrand
2025-07-14 15:23 ` Pedro Falcato
2025-07-14 15:33 ` Liam R. Howlett
2025-07-14 13:00 ` [PATCH 4/5] mm/mseal: separate out and simplify VMA gap check Lorenzo Stoakes
2025-07-14 14:41 ` David Hildenbrand
2025-07-14 15:17 ` Pedro Falcato
2025-07-14 15:23 ` Lorenzo Stoakes
2025-07-14 15:25 ` David Hildenbrand
2025-07-14 15:32 ` Lorenzo Stoakes
2025-07-14 15:40 ` Liam R. Howlett
2025-07-14 15:35 ` Liam R. Howlett
2025-07-14 15:40 ` Lorenzo Stoakes
2025-07-14 15:43 ` Liam R. Howlett
2025-07-14 15:47 ` Lorenzo Stoakes
2025-07-14 13:00 ` [PATCH 5/5] mm/mseal: rework mseal apply logic Lorenzo Stoakes
2025-07-14 15:26 ` Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26a1fc6d-d0c5-4f5c-9669-0593a9a6b59c@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jannh@google.com \
--cc=jeffxu@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pfalcato@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).