From: Markus Elfring <Markus.Elfring@web.de>
To: "Felix Gu" <ustc.gu@gmail.com>, "Heiko Stübner" <heiko@sntech.de>,
"Srinivas Kandagatla" <srini@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons
Date: Tue, 3 Mar 2026 10:25:35 +0100 [thread overview]
Message-ID: <26b4b813-4ded-403b-bcef-3941b4dbd0fb@web.de> (raw)
In-Reply-To: <20260301-qnap-v1-1-8131c9b2d118@gmail.com>
> The nvcfg struct member assignments were incorrectly using commas instead
> of semicolons.
Would a summary phrase like “Prefer separate variable assignment statements
over comma expressions” be more appropriate here?
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc2#n94
Regards,
Markus
next prev parent reply other threads:[~2026-03-03 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 9:51 [PATCH] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons Felix Gu
2026-03-02 11:15 ` Heiko Stuebner
2026-03-03 9:25 ` Markus Elfring [this message]
2026-03-11 11:33 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26b4b813-4ded-403b-bcef-3941b4dbd0fb@web.de \
--to=markus.elfring@web.de \
--cc=heiko@sntech.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srini@kernel.org \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox