From: David Ahern <dsahern@kernel.org>
To: Breno Leitao <leitao@debian.org>,
kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ip6_vti: Do not use custom stat allocator
Date: Thu, 4 Apr 2024 12:08:47 -0600 [thread overview]
Message-ID: <26c51418-0807-4e29-bc48-06a1e31f8016@kernel.org> (raw)
In-Reply-To: <20240404125254.2978650-1-leitao@debian.org>
On 4/4/24 6:52 AM, Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core
> instead of in this driver.
>
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
>
> Remove the allocation in the ip6_vti and leverage the network
> core allocation instead.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> net/ipv6/ip6_vti.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2024-04-04 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 12:52 [PATCH net-next 1/2] ip6_vti: Do not use custom stat allocator Breno Leitao
2024-04-04 12:52 ` [PATCH net-next 2/2] ip6_vti: Remove generic .ndo_get_stats64 Breno Leitao
2024-04-04 18:09 ` David Ahern
2024-04-04 18:08 ` David Ahern [this message]
2024-04-08 10:00 ` [PATCH net-next 1/2] ip6_vti: Do not use custom stat allocator patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26c51418-0807-4e29-bc48-06a1e31f8016@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox