From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A64634AB00 for ; Sun, 5 Jul 2026 07:46:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783237590; cv=none; b=FgLpjUFsdLshtGu4Q89CFTJLBsQHonWGA4cIjM3U9Y24NNCrIGsVQ6I9ehyK9PXRI2lo+aQBDfswakXkLT7lp0bpV4fdNADEKYre8HVNVyJh+bHOJIzUwtlE6fL4DFU9YKXnTMc+Fza5Mco3UjVxCsz+kyDSR8CPra4J9sqgJJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783237590; c=relaxed/simple; bh=Z6qxfLB0hQ60ZJc/fcwtlCkLOpCr27Eeo1hSX068R4w=; h=From:Date:Message-ID:To:Cc:Subject:In-Reply-To:References; b=RtB9wo27al7gYXxX9moHOEVDhDvrm0AOjZlJ/T9VaTh08rSq1XG/1a9rb446McuATbL7v31mlKEloZdqJ5lLaG/2jnDo6hTOc9x60wByJoZfFQKY6YfAIaHFctGXNLZvn9dneTyYz9N9Cp8ZVdThugEQL5clxmj+5fpBPRmDOU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HqQeKiy4; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HqQeKiy4" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-847e6f03df8so2476899b3a.0 for ; Sun, 05 Jul 2026 00:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783237589; x=1783842389; darn=vger.kernel.org; h=references:in-reply-to:subject:cc:to:message-id:date:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Z6qxfLB0hQ60ZJc/fcwtlCkLOpCr27Eeo1hSX068R4w=; b=HqQeKiy4Pxhp3aeACNmAZuIYpiWUn33FNL9w7YaCNPluyXFKmmkvASDCx/rrZsl1x7 7ba1uoeAFKYEJ+g6piaAD7JNK1Sc2w+NcHeZqe2+rgnBYdJ9lnHNwORH9Ua1CEht9bXG F451fvs+xnTKlZnCEA7F3fxd1EcFxQBblTzWsOgIwTnJL0ZsvZ3jn3XMm+XoHRn+jRji bJRiJx3jjaCiHG/qC3QVvheeepOZ+WX7FuIf+y9tfF+ce/Sms0PM9RKhPhPMd9hFwM8r mn1rmnayiX0VeGcUe/m+zJ8+srHN0/0nwbtjFKX3bZ+bANrvg3f75MxTvcpOfZ1KV3nA xKzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783237589; x=1783842389; h=references:in-reply-to:subject:cc:to:message-id:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Z6qxfLB0hQ60ZJc/fcwtlCkLOpCr27Eeo1hSX068R4w=; b=pwDOit74Cp5t7BvwzwZbpjL+1mOrCEsrlNqQLNsr4U1baRlW7wcR2QDKKlJCcFEEOA qvHWuYUsg+3j+RqUXbeCKrxs05FH8d4rCnRrpnJplMgnKrk+XhcRN1X63PX5tdn6ojv8 q5GtWc/YIB1Beijq7NdNR5NeCW7qn85/PxkeOA0PJjBCfyIUZ/ED5K9TrXmnT2O6ODgJ oRRzuZ8zYgoI5ViBMSTDhf35EwgKuOrEUPECtyZ68ugn7fxUdUkI9xP9lv8wzhgxuxDw dUbDWc4KQocywn0UXutH676oofj1JYOfrlvc9piPzOTo/wgB93j9PleHLXPyLtA0dXu/ jNiw== X-Forwarded-Encrypted: i=1; AHgh+Ro+tDXbNcHNu/bsHVZUPqG+5sKvRmaMFykpEFo7e2ZFmro2sAsZI604EevA/4mn5wyx022KIv215pTQNT8=@vger.kernel.org X-Gm-Message-State: AOJu0YzpGnjO9UTC6uwsCDSK7mOo8tL97YQuqSl1ILoqgsb5ut5btW6p /hOoHfOb+EdBf+g0bq/Cfb+xagUTMle1mOLkgWdtpXiCbAY0tSHuZFtvWr0X3ZUaB3g= X-Gm-Gg: AfdE7cmCHiAUCnD96DPXpEFfYO8eRAdu6kkR6RYzJAQ886+M6TLVuUDeq08KolJEzes KbXRoSHr8wlirV21ABQ39QfH9EMrBGEegBhOEnaZ1jHFIQCs4nu2g/RlLi9sTyJfO0fhsKDCC8Q Ui4aJBCrIeYHyDLdlNPUXYNzw/L0krFddzHNr23aQ2vmq9GNiMAjq9628FGQfqEyEB5kKlQKOWJ P4z49lbpwVIlMoURAeijX+lwazRegwLW347A/mC5RbANwlTRknhTNd1ZNfubicdadFI2f7n8h08 +j6cx62nTky5sagMBfgAGNbBJKR8bf68w6oFyWDWogJ123A0nOSfNeq+5B1E/uX9hcW9mPOWUSX d9LmyFyLaonVuozF7Vg6YzSzYViPxvBRd92xU7DL00usPYm8+kzUM1qshRP3CD/U2YfbdOWwwrA /JqW6JMyDBokewXRLzobFhoDOCX7I828J6TWE= X-Received: by 2002:a05:6a00:13aa:b0:845:d650:b75f with SMTP id d2e1a72fcca58-847f6d5a1e8mr5176306b3a.8.1783237588849; Sun, 05 Jul 2026 00:46:28 -0700 (PDT) Received: from localhost ([112.65.12.207]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6d4edb4sm2028187b3a.33.2026.07.05.00.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 00:46:28 -0700 (PDT) From: haohlliang@gmail.com Date: Sun, 05 Jul 2026 15:46:25 +0800 Message-ID: <26c872506bd87b969a84c91d0a7dea9f@gmail.com> To: tglx@kernel.org Cc: linusw@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpio: dwapb: Add robust error handling in interrupt handler In-Reply-To: <875x2vlpjx.ffs@fw13> References: <875x2vlpjx.ffs@fw13> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Hi tglx, Thank you for the thorough review. You're absolutely right that my previous approach was limited to handling the symptom at the crash site without investigating the root cause. After your explanation, I realized the real problem is that the GPIO controller does not properly initialize its interrupt state, and stale interrupt configuration can persist across warm reboots when peripherals remain powered. I'll send a v4 that masks all interrupts at hardware initialization time via the init_hw() callback, which addresses the root cause rather than the symptom. Thanks, Liang