public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Schmid <lukas.schmid@netcube.li>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Maxime Ripard <mripard@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add NetCube Systems Austria name
Date: Thu, 02 Jan 2025 19:48:42 +0100	[thread overview]
Message-ID: <26cbf302f615bec3ed6496f04425edc7@netcube.li> (raw)
In-Reply-To: <7bcb73f5-26ae-4bdd-9bb4-afc1c5b9fc0d@kernel.org>

Am 2025-01-02 19:31, schrieb Krzysztof Kozlowski:
> On 02/01/2025 19:24, Lukas Schmid wrote:
>> Am 2025-01-02 18:57, schrieb Krzysztof Kozlowski:
>>> On 02/01/2025 18:49, Lukas Schmid wrote:
>>>> Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li>
>>>> ---
>>>>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>>> 
>>> You did not read really the messages we gave you...
>>> 
>>> 1. Read what I wrote in my first reply for v1. I gave detailed
>>> instruction to avoid the exact mistake you now did.
>>> 
>>> 2. Read again Andre's reply.
>>> 
>>> 3. Do not attach (thread) your patchsets to some other threads
>>> (unrelated or older versions). This buries them deep in the mailbox 
>>> and
>>> might interfere with applying entire sets.
>>> 
>>> 4. Next version, with proper cover letter, is after 24h, so you have
>>> some time to digest the feedback.
>>> 
>>> Best regards,
>>> Krzysztof
>> 
>> Hi,
>> 
>> Thank you for your feedback, and I sincerely apologize for the 
>> mistakes
>> in my submission process.
>> 
>> I did read Andre's reply and your feedback on v1, but unfortunately, I
>> had already sent the v2 series as a reply before fully understanding 
>> all
>> the recommendations. I realize now that this was a misstep and caused
>> confusion.
>> 
>> I will wait until tomorrow, around 20:00, to send the v3 series. I 
>> will
>> make sure to include a proper cover letter and ensure that all the
>> feedback from v1 and v2 is addressed.
>> 
>> Regarding the v1 feedback, I thought I had incorporated all your
>> suggestions. However, after rereading it, I seem to have missed
>> something critical. Could you please point out what I might have
>> overlooked? I want to make sure I fully understand and correct it in 
>> the
>> next iteration.
>> 
> Please read my full reply for v1 of this patch. How did you implement
> that feedback - long instruction?
> 
> Best regards,
> Krzysztof

I assume by 'long instruction' you mean checking the devicetree using
'make dtbs_check W=1'.

I did run dtbs_check after already applying some of the changes you had
recommended. I just had a look at it's output again, and see now that 
there
is one more issue about 'pinctrl@1c20800: 'gpio-reserved-ranges' does 
not
match any of the regexes'.

Is this what you mean?

If thats the case I'd assume I should add another patch which adds the
'gpio-reserved-ranges' property to the
'devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml' file.

Best regards,
Lukas


  reply	other threads:[~2025-01-02 18:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 15:05 [PATCH 1/3] dt-bindings: vendor-prefixes: Add NetCube Systems Austria name Lukas Schmid
2025-01-02 15:05 ` [PATCH 2/3] dt-bindings: arm: sunxi: Add NetCube Systems Kumquat board Lukas Schmid
2025-01-02 16:17   ` Krzysztof Kozlowski
2025-01-02 15:05 ` [PATCH 3/3] ARM: dts: sunxi: add support for NetCube Systems Kumquat Lukas Schmid
2025-01-02 16:15   ` Krzysztof Kozlowski
2025-01-02 17:14     ` Lukas Schmid
2025-01-02 17:45       ` Chen-Yu Tsai
2025-01-02 17:54       ` Andre Przywara
2025-01-02 17:49     ` Lukas Schmid
2025-01-02 17:49       ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add NetCube Systems Austria name Lukas Schmid
2025-01-02 17:57         ` Krzysztof Kozlowski
2025-01-02 18:24           ` Lukas Schmid
2025-01-02 18:31             ` Krzysztof Kozlowski
2025-01-02 18:48               ` Lukas Schmid [this message]
2025-01-02 20:59                 ` Krzysztof Kozlowski
2025-01-02 21:09                   ` Lukas Schmid
2025-01-02 17:50       ` [PATCH v2 2/3] dt-bindings: arm: sunxi: Add NetCube Systems Kumquat board Lukas Schmid
2025-01-02 17:50       ` [PATCH v2 3/3] ARM: dts: sunxi: add support for NetCube Systems Kumquat Lukas Schmid
2025-01-02 16:17 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add NetCube Systems Austria name Krzysztof Kozlowski
2025-01-03 15:20 ` Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26cbf302f615bec3ed6496f04425edc7@netcube.li \
    --to=lukas.schmid@netcube.li \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox