From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CD433B6350 for ; Fri, 17 Apr 2026 10:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776421916; cv=none; b=PJegPzoBBPXtvXnkoP6q8dWbhGTOYEVg+pQ2tPup/LPjAMXZopN8A9LzFAGrfEKgbsPa47PeNMU/alTqR7JMgYhR6EgJbj/AQsA6WKFNXqIAz6f7msFfJ++9Klg5OgxJlx3C+a693FuutaLup17sBtLt8RCLYHvlu8tLvccd2wA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776421916; c=relaxed/simple; bh=dMSa1ZYVHAXRfZPoqn3DEJ0kYY0h2KvNjupT0MmylvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qnjqavGf6ZUJXEmzIAcDJYgeg9u2MvgXd9a9zlz3dtKS606c1fOw7xZsAwYdlTgS09kHWKMYv8SEUtkJfSUOjSZUueWLuuoXpMe7jgqtetOihZF7qRTuykAia3rKJJMOnfPVnXYlxsM8QqxSQn35BjPu92NOwbqqo6JrtX+lFqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YvvxRw5v; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YvvxRw5v" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-43cff5dafc3so366876f8f.1 for ; Fri, 17 Apr 2026 03:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776421914; x=1777026714; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0D9fB9YPS5bWDOTVeNiq3WO6cAOHLgc4jMTJXbNx0ZY=; b=YvvxRw5v1rtC5mI8Q94ah73K5qcyCR/1XdcNq/9SYmeLO6tLoISzG51eY5hMtY5GH8 wb/d/S+yWF3AWzjI4b1V8mLibyr3pD7GdcVqvojAN0C6gNcSzi3pt6c18GtxKnqZvLE/ 3BR7aOte4/ox06kkRxQcX6un+rxLyEHbG3u7tw0zRBr7BZHWezUkUMYGuCJf5OS2WOEI Hm2I8NdK5NPOLufPjLpZXtON4uJWA9YVWR0J2gllLQqAyF/QijydMW/0KJTSy89BD3sk s4zob6wf9XPNTfrVn/ScMnwSW4vWZgt5t342tkyYKkxjQZ+83XFdRPDaTN2b2IWfPsMy xPVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776421914; x=1777026714; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0D9fB9YPS5bWDOTVeNiq3WO6cAOHLgc4jMTJXbNx0ZY=; b=H1z/ZLUGOx4rlW/AiWTR7+Gy8WCAsi6+xbnoMm3fg+8fwXc3p3XcDZs6zmX5X+AH2F ZdgapJ7C1L5Cje+vJ462OI1A0f+2xZjhdoM1zitrF7aNfirwReuQKqoT7um3RUE/i6IJ neMAlOlqzZVCs66nE/zlkSCaOV87Dd07NYq4e+MnGOGz34BJyes8DmqRR0TrYOXPUtdE 0h60pDSiP96PQUKEuRs1u5FD8vkCR8XvHsOZaRHeErRHK1MGGXo0ey8o5U5qSGn4l6KZ InEAVimrKczTY7xzy8XChuMjOGCPQpvnk8f5hrsFfAORX0jHZX/KSFPmR1YwjFNkqyvh rWbw== X-Forwarded-Encrypted: i=1; AFNElJ8+BY6ioxjeSpbaXPy2UPHSsKlmNS6WZqVeQ+sKIZ71vPD23U/GzKFFIMM8hsGRouc6NeSIqaEuq2JSk4E=@vger.kernel.org X-Gm-Message-State: AOJu0YwrjqD/8rWGtocWmKzNc4PaHvTvamPMUEHZK1bTuup+5LofejN0 iOiVgfkWGTlbVFbhOE2CJwUDJfkCjA5S7+qGh4G5sUi72LxyBcHMU8us X-Gm-Gg: AeBDieuVKVai5YcM/XxcZryRCJ+lCKxf2lCA74EZsKwlUNHfk3/5H/bIP/D7SgscF7r BaVBeA0igcCHeI8vffAVcdwdWLxyA+M69EdLJscvsrJD2WgFCtxd5Ssg1c3b5304c/k+6NUeIhk e2XHDM/HaOVg3ObyAL5vOZAiPjSMjUjesKfACMzB9tC6YQIQqpLmyQNHNQbnGK0jqo9F2Cdd9RK EPdu/xlN+4ftKd8/2Kq9mpjlPJKTmoe3ZgLWK8TYAby8tD3X6iuQFTObnHVMM71YoyHL1HLaxez bmS2GK4t3J3bsR4B6HW32AelvMBPPan4vm7+M0cQV38ATc8vRkXvd4Tjz4IRZU5CtCumdM3PyMT xG/rLQLVHzDPjgkYxUBIQx+IJ3RR5mYbqYJrojCBUcaDsynAc7E3V4M1pIG14U02F/Q5Xc0DENj GL8pS7N0rAm1XXcXrj+QdVBVf0TtPlWDfo0fxoXY/UGxXIlV4= X-Received: by 2002:a05:6000:22c5:b0:43d:6fb7:fedb with SMTP id ffacd0b85a97d-43fe3e1645emr3218314f8f.36.1776421913626; Fri, 17 Apr 2026 03:31:53 -0700 (PDT) Received: from [192.168.1.169] ([46.10.223.24]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e46898sm3395465f8f.27.2026.04.17.03.31.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 03:31:53 -0700 (PDT) Message-ID: <26cd0656-ca76-4cb7-9f1e-b8c042a7e2cb@gmail.com> Date: Fri, 17 Apr 2026 13:31:52 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] serial: mxs-auart: Compare the return value of gpiod_get_direction against GPIO_LINE_DIRECTION_IN To: Frank Li Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20260416083254.1798-1-zlatistiv@gmail.com> Content-Language: en-US From: "Nikola Z. Ivanov" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/17/26 11:22 AM, Frank Li wrote: > On Thu, Apr 16, 2026 at 11:32:54AM +0300, Nikola Z. Ivanov wrote: > > subjust suggest change to > > Replace hardcode 1 with predefined macro GPIO_LINE_DIRECTION_IN > > Frank Hello, I suppose you are suggesting a subject change, in that case I will send v2. Also I can see that automated code review notes that this will not build on greg's tty tree as 7.0 is not yet merged into it. I will wait for that to happen before mailing v2. BR, Nikola > >> The GPIO_LINE_DIRECTION_* definitions have just recently been exposed to >> gpio consumers.h by breaking them out in a separate defs.h file. >> >> Use this to validate the gpio direction instead of the hard-coded literal. >> >> Signed-off-by: Nikola Z. Ivanov >> --- >> drivers/tty/serial/mxs-auart.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c >> index cc65c9fb6446..6c6df4d5c21f 100644 >> --- a/drivers/tty/serial/mxs-auart.c >> +++ b/drivers/tty/serial/mxs-auart.c >> @@ -1519,7 +1519,7 @@ static int mxs_auart_init_gpios(struct mxs_auart_port *s, struct device *dev) >> >> for (i = 0; i < UART_GPIO_MAX; i++) { >> gpiod = mctrl_gpio_to_gpiod(s->gpios, i); >> - if (gpiod && (gpiod_get_direction(gpiod) == 1)) >> + if (gpiod && (gpiod_get_direction(gpiod) == GPIO_LINE_DIRECTION_IN)) >> s->gpio_irq[i] = gpiod_to_irq(gpiod); >> else >> s->gpio_irq[i] = -EINVAL; >> -- >> 2.53.0 >>