From: Bastien Curutchet <bastien.curutchet@bootlin.com>
To: Rob Herring <robh@kernel.org>, Peter Rosin <peda@axentia.se>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Korsgaard <peter.korsgaard@barco.com>,
Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
Christopher Cordahi <christophercordahi@nanometrics.ca>
Subject: Re: [PATCH v2 1/3] dt-bindings: i2c: gpio: Add 'transition-delay-us' property
Date: Wed, 5 Jun 2024 14:32:35 +0200 [thread overview]
Message-ID: <26e9970c-7dbf-48ac-9832-58bf2952d350@bootlin.com> (raw)
In-Reply-To: <20240603155810.GA509311-robh@kernel.org>
Hi Rob, Hi Peter,
On 6/3/24 17:58, Rob Herring wrote:
> On Wed, May 29, 2024 at 02:13:37PM +0200, Peter Rosin wrote:
>> Hi!
>>
>> 2024-05-29 at 11:17, Bastien Curutchet wrote:
>>> I2C MUXes described by the i2c-gpio-mux sometimes need a significant
>>> amount of time to switch from a bus to another. When a new bus is
>>> selected, the first I2C transfer can fail if it occurs too early. There
>>> is no way to describe this transition delay that has to be waited before
>>> starting the first I2C transfer.
>>>
>>> Add a 'transition-delay-us' property that indicates the delay to be
>>> respected before doing the first i2c transfer.
>>
>> The io-channel-mux has a property with very similar intent named
>> settle-time-us [1]. I think we should use the same name here.
>>
>> [1] Documentation/devicetree/bindings/iio/multiplexer/io-channel-mux.yaml
>
> Agreed. I knew we had something and went looking... I only checked the
> base mux and i2c mux bindings.
>
Ok I'll do this in V3, thank you.
Best regards
Bastien
next prev parent reply other threads:[~2024-06-05 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 9:17 [PATCH v2 0/3] i2c: mux: gpio: Add 'transition-delay-us' property Bastien Curutchet
2024-05-29 9:17 ` [PATCH v2 1/3] dt-bindings: i2c: " Bastien Curutchet
2024-05-29 12:13 ` Peter Rosin
2024-06-03 15:58 ` Rob Herring
2024-06-05 12:32 ` Bastien Curutchet [this message]
2024-05-29 9:17 ` [PATCH v2 2/3] i2c: mux: gpio: Re-order #include to match alphabetic order Bastien Curutchet
2024-05-29 9:17 ` [PATCH v2 3/3] i2c: mux: gpio: Add support for the 'transition-delay-us' property Bastien Curutchet
2024-05-29 12:16 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26e9970c-7dbf-48ac-9832-58bf2952d350@bootlin.com \
--to=bastien.curutchet@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=christophercordahi@nanometrics.ca \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter.korsgaard@barco.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox