From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>,
morbidrsa@gmail.com, wim@linux-watchdog.org
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: mena21_wdt: Fix a possible data race in a21_wdt_set_timeout
Date: Tue, 8 May 2018 11:32:20 +0800 [thread overview]
Message-ID: <26fde8a3-fb78-e12f-2f0f-c9b5bb2158e0@gmail.com> (raw)
In-Reply-To: <64e08944-0578-ac4c-8dea-e1e704685e77@roeck-us.net>
On 2018/5/8 11:28, Guenter Roeck wrote:
> On 05/07/2018 08:18 PM, Jia-Ju Bai wrote:
>> The write operation to "wdt->timeout" is protected by
>> the lock on line 118, but the read operation to
>> this data on line 105 is not protected by the lock.
>> Thus, there may exist a data race for "wdt->timeout".
>>
>> To fix this data race, the read operation to "wdt->timeout"
>> should be also protected by the lock.
>>
>
> There is no race. There is already a mutex in the watchdog core which
> serializes
> calls to the various API functions. It would make more sense to drop
> drv->lock
> from the driver.
>
Thanks for your reply :)
Need I submit a patch of dropping all calls to "drv->lock"?
Best wishes,
Jia-Ju Bai
next prev parent reply other threads:[~2018-05-08 3:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 3:18 [PATCH] watchdog: mena21_wdt: Fix a possible data race in a21_wdt_set_timeout Jia-Ju Bai
2018-05-08 3:28 ` Guenter Roeck
2018-05-08 3:32 ` Jia-Ju Bai [this message]
2018-05-08 3:42 ` Guenter Roeck
2018-05-08 3:47 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26fde8a3-fb78-e12f-2f0f-c9b5bb2158e0@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=morbidrsa@gmail.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox