From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753218AbdFOPM3 (ORCPT ); Thu, 15 Jun 2017 11:12:29 -0400 Received: from gloria.sntech.de ([95.129.55.99]:36188 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752712AbdFOPM2 (ORCPT ); Thu, 15 Jun 2017 11:12:28 -0400 From: Heiko Stuebner To: Finley Xiao Cc: srinivas.kandagatla@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, huangtao@rock-chips.com, tony.xie@rock-chips.com, cl@rock-chips.com, frank.wang@rock-chips.com Subject: Re: [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse Date: Thu, 15 Jun 2017 17:12:15 +0200 Message-ID: <2703081.pOfGv2HUEs@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1494557060-105230-1-git-send-email-finley.xiao@rock-chips.com> References: <1494557060-105230-1-git-send-email-finley.xiao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 12. Mai 2017, 10:44:20 CEST schrieb Finley Xiao: > This adds the necessary data for handling eFuse on the rk322x. > > Signed-off-by: Finley Xiao > --- > Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 + > drivers/nvmem/rockchip-efuse.c | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt > index 94aeeea..194926f 100644 > --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt > +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt > @@ -4,6 +4,7 @@ Required properties: > - compatible: Should be one of the following. > - "rockchip,rk3066a-efuse" - for RK3066a SoCs. > - "rockchip,rk3188-efuse" - for RK3188 SoCs. > + - "rockchip,rk322x-efuse" - for RK322x SoCs. should be rockchip,rk3228-efuse. While rk3228 and rk3229 are pratically the same soc, the compatible still shouldn't contain placeholders. Heiko > - "rockchip,rk3288-efuse" - for RK3288 SoCs. > - "rockchip,rk3399-efuse" - for RK3399 SoCs. > - reg: Should contain the registers location and exact eFuse size > diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c > index 423907b..a0d4ede 100644 > --- a/drivers/nvmem/rockchip-efuse.c > +++ b/drivers/nvmem/rockchip-efuse.c > @@ -170,6 +170,10 @@ static const struct of_device_id rockchip_efuse_match[] = { > .data = (void *)&rockchip_rk3288_efuse_read, > }, > { > + .compatible = "rockchip,rk322x-efuse", > + .data = (void *)&rockchip_rk3288_efuse_read, > + }, > + { > .compatible = "rockchip,rk3288-efuse", > .data = (void *)&rockchip_rk3288_efuse_read, > }, >