* Re: [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse
2017-05-12 2:44 [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse Finley Xiao
@ 2017-05-15 20:45 ` Rob Herring
2017-06-05 3:51 ` Frank Wang
2017-06-15 15:12 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2017-05-15 20:45 UTC (permalink / raw)
To: Finley Xiao
Cc: srinivas.kandagatla, mark.rutland, heiko, linux-arm-kernel,
linux-rockchip, devicetree, linux-kernel, huangtao, tony.xie, cl,
frank.wang
On Fri, May 12, 2017 at 10:44:20AM +0800, Finley Xiao wrote:
> This adds the necessary data for handling eFuse on the rk322x.
>
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> ---
> Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
> drivers/nvmem/rockchip-efuse.c | 4 ++++
> 2 files changed, 5 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse
2017-05-12 2:44 [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse Finley Xiao
2017-05-15 20:45 ` Rob Herring
@ 2017-06-05 3:51 ` Frank Wang
2017-06-15 15:12 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Frank Wang @ 2017-06-05 3:51 UTC (permalink / raw)
To: Finley Xiao, heiko
Cc: srinivas.kandagatla, robh+dt, mark.rutland, linux-arm-kernel,
linux-rockchip, devicetree, linux-kernel, huangtao, tony.xie, cl,
wmc
Hi Finley,
On 2017/5/12 10:44, Finley Xiao wrote:
> This adds the necessary data for handling eFuse on the rk322x.
>
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> ---
> Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
> drivers/nvmem/rockchip-efuse.c | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> index 94aeeea..194926f 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> @@ -4,6 +4,7 @@ Required properties:
> - compatible: Should be one of the following.
> - "rockchip,rk3066a-efuse" - for RK3066a SoCs.
> - "rockchip,rk3188-efuse" - for RK3188 SoCs.
> + - "rockchip,rk322x-efuse" - for RK322x SoCs.
As the comments from Heiko in other patches, compatibles should not
contain wildcards, so could you please make this
"rockchip,rk3228-efuse"
instead?
> - "rockchip,rk3288-efuse" - for RK3288 SoCs.
> - "rockchip,rk3399-efuse" - for RK3399 SoCs.
> - reg: Should contain the registers location and exact eFuse size
> diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c
> index 423907b..a0d4ede 100644
> --- a/drivers/nvmem/rockchip-efuse.c
> +++ b/drivers/nvmem/rockchip-efuse.c
> @@ -170,6 +170,10 @@ static const struct of_device_id rockchip_efuse_match[] = {
> .data = (void *)&rockchip_rk3288_efuse_read,
> },
> {
> + .compatible = "rockchip,rk322x-efuse",
> + .data = (void *)&rockchip_rk3288_efuse_read,
> + },
The same as above.
BR.
Frank
> + {
> .compatible = "rockchip,rk3288-efuse",
> .data = (void *)&rockchip_rk3288_efuse_read,
> },
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse
2017-05-12 2:44 [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse Finley Xiao
2017-05-15 20:45 ` Rob Herring
2017-06-05 3:51 ` Frank Wang
@ 2017-06-15 15:12 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2017-06-15 15:12 UTC (permalink / raw)
To: Finley Xiao
Cc: srinivas.kandagatla, robh+dt, mark.rutland, linux-arm-kernel,
linux-rockchip, devicetree, linux-kernel, huangtao, tony.xie, cl,
frank.wang
Am Freitag, 12. Mai 2017, 10:44:20 CEST schrieb Finley Xiao:
> This adds the necessary data for handling eFuse on the rk322x.
>
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> ---
> Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
> drivers/nvmem/rockchip-efuse.c | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> index 94aeeea..194926f 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> @@ -4,6 +4,7 @@ Required properties:
> - compatible: Should be one of the following.
> - "rockchip,rk3066a-efuse" - for RK3066a SoCs.
> - "rockchip,rk3188-efuse" - for RK3188 SoCs.
> + - "rockchip,rk322x-efuse" - for RK322x SoCs.
should be rockchip,rk3228-efuse.
While rk3228 and rk3229 are pratically the same soc, the compatible still
shouldn't contain placeholders.
Heiko
> - "rockchip,rk3288-efuse" - for RK3288 SoCs.
> - "rockchip,rk3399-efuse" - for RK3399 SoCs.
> - reg: Should contain the registers location and exact eFuse size
> diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c
> index 423907b..a0d4ede 100644
> --- a/drivers/nvmem/rockchip-efuse.c
> +++ b/drivers/nvmem/rockchip-efuse.c
> @@ -170,6 +170,10 @@ static const struct of_device_id rockchip_efuse_match[] = {
> .data = (void *)&rockchip_rk3288_efuse_read,
> },
> {
> + .compatible = "rockchip,rk322x-efuse",
> + .data = (void *)&rockchip_rk3288_efuse_read,
> + },
> + {
> .compatible = "rockchip,rk3288-efuse",
> .data = (void *)&rockchip_rk3288_efuse_read,
> },
>
^ permalink raw reply [flat|nested] 4+ messages in thread