From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4137BC433E0 for ; Fri, 12 Jun 2020 14:15:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F9122067B for ; Fri, 12 Jun 2020 14:15:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b+BVs5SQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726396AbgFLOPo (ORCPT ); Fri, 12 Jun 2020 10:15:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbgFLOPo (ORCPT ); Fri, 12 Jun 2020 10:15:44 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB0AEC03E96F; Fri, 12 Jun 2020 07:15:42 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id 9so11241958ljv.5; Fri, 12 Jun 2020 07:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=jUPXON52cqSIobsRf11C/vw7kKmTCd4Mw6QenfguMkk=; b=b+BVs5SQ7G5VNUx71IxUn2irlrb6TLlJrqmq9kpPo7doYjO2oxcEL4LdhbftEOzPA5 fsvD+fFo5Us0Xk3YfdX8V2d1ppm3m+9EPgmm5+9YM9PlxL1z72PL1MLknlHPV5MkTsq8 gKwilzuByG4/ujfUfIQ/MpVXdKlMMz90Sd4Q2Q0Yd3FCQHTnzKMEmRxJ3qIyDI+k5pUG MG0U/hb7zRwtkZkOyRTckulVRMsMo7lOoL0jBqrFj8DKuycpdi38zaNvS8DKd74Q2m2T +KVG1njga0oxFp/iTo+ejngKZdZBiDbnWDMCBzC7D8IeKijY9FDzTvut922J+sqn/JLK 2dqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jUPXON52cqSIobsRf11C/vw7kKmTCd4Mw6QenfguMkk=; b=Q3nVhIixMFRgBc3HNTDSgY2HEgfT7zWIglX8+Es5b8ibjUkrbpaiLBLuvVRUW0E6LN 44jpuV+FdTtNX+0+GimEr23l3CtNuwQqnUk06Y1B1L61ucLej9+/yhET/WFEbDnBatY/ GUjmGvD2BW7NLJEhSirenS5UykSGGARop+VUalupuBqgrMHb57oRtBqzVVw8hhdqgLKJ Sb9HlyHjdz9wjJlmsPhSpdMycLaxvn9EtWR6lcNvYsgtMcObad6Af97aZqsXOSopnv0T N+RXRhFWhIgFQPXraVDT5m3V4NYdQSM2gcWidLbGSJfHZTOdFrEAtGR2wxMNGkVi+tiF 0dIA== X-Gm-Message-State: AOAM531HfvoSRkI5P4DsSZqxel0U4363CusB1iB+Cp0WtQ7ksmPbFRs1 OepctCqUmY589huN6Fzrla/otw1J X-Google-Smtp-Source: ABdhPJwSG1HU8X+Y3fxojFr7FuVJjUzgWfMr+hqPDTSPnE+xia2Tebtekt1zoCQQ4YJCr1d7qPZBbQ== X-Received: by 2002:a2e:8e82:: with SMTP id z2mr6645322ljk.71.1591971340899; Fri, 12 Jun 2020 07:15:40 -0700 (PDT) Received: from [192.168.2.145] (79-139-237-54.dynamic.spd-mgts.ru. [79.139.237.54]) by smtp.googlemail.com with ESMTPSA id k7sm1925629lfd.53.2020.06.12.07.15.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2020 07:15:40 -0700 (PDT) Subject: Re: [PATCH] memory: tegra: Avoid double error messaging when IRQ absent To: Keyur Patel , Thierry Reding , Jonathan Hunter , Peter De Schrijver , Kate Stewart , Greg Kroah-Hartman , Thomas Gleixner , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200611190758.172605-1-iamkeyur96@gmail.com> From: Dmitry Osipenko Message-ID: <2707086c-e604-d0d6-66fa-072e5844e923@gmail.com> Date: Fri, 12 Jun 2020 17:15:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200611190758.172605-1-iamkeyur96@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 11.06.2020 22:07, Keyur Patel пишет: > Since the commit 7723f4c ("driver core: platform: Add an error message > to platform_get_irq*()") platform_get_irq() started issuing an error message. > Thus, there is no need to have the same in the driver. > > Signed-off-by: Keyur Patel > --- > drivers/memory/tegra/mc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c > index ec8403557ed4..f519c0987485 100644 > --- a/drivers/memory/tegra/mc.c > +++ b/drivers/memory/tegra/mc.c > @@ -659,10 +659,8 @@ static int tegra_mc_probe(struct platform_device *pdev) > } > > mc->irq = platform_get_irq(pdev, 0); > - if (mc->irq < 0) { > - dev_err(&pdev->dev, "interrupt not specified\n"); > + if (mc->irq < 0) > return mc->irq; > - } > > WARN(!mc->soc->client_id_mask, "missing client ID mask for this SoC\n"); > > Reviewed-by: Dmitry Osipenko