From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753614AbdIDNck (ORCPT ); Mon, 4 Sep 2017 09:32:40 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:36008 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbdIDNci (ORCPT ); Mon, 4 Sep 2017 09:32:38 -0400 X-AuditID: b6c32a45-f79466d000002ac6-77-59ad55f36e9d From: Bartlomiej Zolnierkiewicz To: Vladis Dronov Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: aty: do not leak uninitialized padding in clk to userspace Date: Mon, 04 Sep 2017 15:32:32 +0200 Message-id: <2710268.UQ4S50vCLC@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170829135004.5739-1-vdronov@redhat.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsWy7bCmqe7n0LWRBotWKVic6PvAanF51xw2 i1dfFzM6MHu833eVzePzJrkApigum5TUnMyy1CJ9uwSujO/ftjMXzGWpePjhMXsD4yHmLkZO DgkBE4nL/RsYIWwxiQv31rN1MXJxCAnsYJRYffkqC4TznVFiw7EHbDAd01e1M0IkdjNKNG3s Y4JwvjJKPHy+E6yKTcBKYmL7KqAqdg4RATWJA5YgUWYBW4nXp8+AbRMWiJfYu3UDC4jNIqAq 0XPkB1icV0BT4vbxd0wgtqiAl8SWfe1gNqeAuURD82kmiBpBiR+T77FAzJSX2Ld/KiuErSNx 9tg6sNskBHrYJBrv/mCBONpF4va+uUwQtrDEq+Nb2CFsaYlnqzZCvT+dUWL7bwmI5s2MEqt2 T4AqspY4fPwi1AY+iY7Df4HiHEBxXomONiGIEg+JH+tbWSFsR4kzNy+D7RIS6GKUuD3PYAKj 3Cwkd89CcvcsJHcvYGRexSiWWlCcm55abFRgqFecmFtcmpeul5yfu4kRHPVarjsYZ5zzOcQo wMGoxMOrcHNNpBBrYllxZe4hRgkOZiUR3hPBayOFeFMSK6tSi/Lji0pzUosPMUpzsCiJ89Zv uxYhJJCeWJKanZpakFoEk2Xi4JRqYJwvyzh1yt4ZQentIdt2sFvdD7RY0RA2u7TMabtsZUBE 6pqaA8eyP7WLBjNMevL9ya6I6aylixnLmnQzFcwc3O89rT1hukds069PR56XXVRdd2yZsJan 5J2FPbWF59+mhn1cofbxCFflHA+B78Vdagc2FjcxbH8tZPXpm89B2cI7Wf71fcwr3ZVYijMS DbWYi4oTAUXXd+/2AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrALMWRmVeSWpSXmKPExsVy+t9jAd1PoWsjDW4uFrc40feB1eLyrjls Fq++LmZ0YPZ4v+8qm8fnTXIBTFFcNimpOZllqUX6dglcGd+/bWcumMtS8fDDY/YGxkPMXYyc HBICJhLTV7UzdjFycQgJ7GSUOHBwPxuE85VRovn0Z1aQKjYBK4mJ7auAqtg5RATUJA5YgkSZ BWwlXp8+wwhiCwvES+zduoEFxGYRUJXoOfIDLM4roClx+/g7JhBbVMBLYsu+djCbU8BcoqH5 NBPEqh5GiV93HrFBNAhK/Jh8jwVigbzEvv1TWSFsLYn1O48zTWDkn4WkbBaSsllIyhYwMq9i lEwtKM5Nzy02KjDKSy3XK07MLS7NS9dLzs/dxAgMx22Htfp3MD5eEn+IUYCDUYmHV+Hmmkgh 1sSy4srcQ4wSHMxKIrwngtdGCvGmJFZWpRblxxeV5qQWH2KU5mBREufN7JsRKSSQnliSmp2a WpBaBJNl4uCUamC0t2+LzDrKo3qoXViRT/rSc5uGoAtZzbFfBebK/z1zsFDMxq9yS/HuwFyd C4aer7SrY3bPs+kr/Lwne/LjsicSp3+e83yrtD/SbFLrtBQBLr3Xi7xFjtmt5NBJret0X/Z8 72KB6w+aj8havnb8MiFe5PieDObPbvL1D1Z1tu3w/b1g2g/+8pNKLMUZiYZazEXFiQACgSrm QwIAAA== X-CMS-MailID: 20170904133234epcas2p47577cae169cc3649c3e02a4561eed0fb X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20170829135015epcas3p2c8daeacf3b6b2960cf13f225231b19c2 X-RootMTR: 20170829135015epcas3p2c8daeacf3b6b2960cf13f225231b19c2 References: <20170829135004.5739-1-vdronov@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, August 29, 2017 03:50:04 PM Vladis Dronov wrote: > 'clk' is copied to a userland with padding byte(s) after 'vclk_post_div' > field unitialized, leaking data from the stack. Fix this ensuring all of > 'clk' is initialized to zero. > > References: https://github.com/torvalds/linux/pull/441 > Reported-by: sohu0106 > Signed-off-by: Vladis Dronov Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics